Re: [Mesa-dev] [PATCH] nir: special hack for TGSI vs indirect inputs

2016-01-12 Thread Christian König
Am 11.01.2016 um 20:55 schrieb Marek Olšák: On Mon, Jan 11, 2016 at 8:00 PM, Rob Clark wrote: On Mon, Jan 11, 2016 at 1:52 PM, Marek Olšák wrote: On Mon, Jan 11, 2016 at 6:07 PM, Rob Clark wrote: Quite possibly I am.. although wouldn't I still have the same issue with other state trackers?

Re: [Mesa-dev] [PATCH] nir: special hack for TGSI vs indirect inputs

2016-01-11 Thread Marek Olšák
On Mon, Jan 11, 2016 at 8:00 PM, Rob Clark wrote: > On Mon, Jan 11, 2016 at 1:52 PM, Marek Olšák wrote: >> On Mon, Jan 11, 2016 at 6:07 PM, Rob Clark wrote: >>> Quite possibly I am.. although wouldn't I still have the same issue >>> with other state trackers? So in that case I'd have to detect

Re: [Mesa-dev] [PATCH] nir: special hack for TGSI vs indirect inputs

2016-01-11 Thread Rob Clark
On Mon, Jan 11, 2016 at 1:52 PM, Marek Olšák wrote: > On Mon, Jan 11, 2016 at 6:07 PM, Rob Clark wrote: >> Quite possibly I am.. although wouldn't I still have the same issue >> with other state trackers? So in that case I'd have to detect >> indirect access, but without ArrayID's, and still se

Re: [Mesa-dev] [PATCH] nir: special hack for TGSI vs indirect inputs

2016-01-11 Thread Marek Olšák
On Mon, Jan 11, 2016 at 6:07 PM, Rob Clark wrote: > Quite possibly I am.. although wouldn't I still have the same issue > with other state trackers? So in that case I'd have to detect > indirect access, but without ArrayID's, and still set this flag. Yes, PIPE_SHADER_CAP_TGSI_ANY_INOUT_DECL_RAN

Re: [Mesa-dev] [PATCH] nir: special hack for TGSI vs indirect inputs

2016-01-11 Thread Ilia Mirkin
Yes the countless other state trackers which emit indirect loads on inputs... I think you can safely just assert if it happens :) On Mon, Jan 11, 2016 at 12:07 PM, Rob Clark wrote: > Quite possibly I am.. although wouldn't I still have the same issue > with other state trackers? So in that

Re: [Mesa-dev] [PATCH] nir: special hack for TGSI vs indirect inputs

2016-01-11 Thread Rob Clark
Quite possibly I am.. although wouldn't I still have the same issue with other state trackers? So in that case I'd have to detect indirect access, but without ArrayID's, and still set this flag. BR, -R On Mon, Jan 11, 2016 at 11:47 AM, Ilia Mirkin wrote: > Are you looking for PIPE_SHADER_CAP_T

Re: [Mesa-dev] [PATCH] nir: special hack for TGSI vs indirect inputs

2016-01-11 Thread Ilia Mirkin
Are you looking for PIPE_SHADER_CAP_TGSI_ANY_INOUT_DECL_RANGE perchance? On Mon, Jan 11, 2016 at 11:44 AM, Rob Clark wrote: > From: Rob Clark > > TGSI doesn't know about array input (or output[*]) variables. If the > INPUT file is addressed indirectly, we must treat the entire INPUT > "register

[Mesa-dev] [PATCH] nir: special hack for TGSI vs indirect inputs

2016-01-11 Thread Rob Clark
From: Rob Clark TGSI doesn't know about array input (or output[*]) variables. If the INPUT file is addressed indirectly, we must treat the entire INPUT "register file" as one contiguous array. However tgsi_to_nir cannot declare all the inputs as a single array var, as this would loose varying s