Re: [Mesa-dev] [PATCH] nir: silence a couple new compiler warnings

2019-03-11 Thread Timothy Arceri
On 12/3/19 1:50 pm, Brian Paul wrote: Thanks, but it looks like Alyssa's patches may be better. -Brian The second patch looks really wrong. Seems like a mistake to me. On 03/11/2019 08:33 PM, Timothy Arceri wrote: Thanks Reviewed-by: Timothy Arceri On 12/3/19 1:12 pm, Brian Paul wrote:

Re: [Mesa-dev] [PATCH] nir: silence a couple new compiler warnings

2019-03-11 Thread Brian Paul
Thanks, but it looks like Alyssa's patches may be better. -Brian On 03/11/2019 08:33 PM, Timothy Arceri wrote: Thanks Reviewed-by: Timothy Arceri On 12/3/19 1:12 pm, Brian Paul wrote: [33/630] Compiling C object 'src/compiler/nir/nir@sta/nir_loop_analyze.c.o'. ../src/compiler/nir/nir_loop_a

Re: [Mesa-dev] [PATCH] nir: silence a couple new compiler warnings

2019-03-11 Thread Timothy Arceri
Thanks Reviewed-by: Timothy Arceri On 12/3/19 1:12 pm, Brian Paul wrote: [33/630] Compiling C object 'src/compiler/nir/nir@sta/nir_loop_analyze.c.o'. ../src/compiler/nir/nir_loop_analyze.c: In function ‘try_find_trip_count_vars_in_iand’: ../src/compiler/nir/nir_loop_analyze.c:846:29: warning:

[Mesa-dev] [PATCH] nir: silence a couple new compiler warnings

2019-03-11 Thread Brian Paul
[33/630] Compiling C object 'src/compiler/nir/nir@sta/nir_loop_analyze.c.o'. ../src/compiler/nir/nir_loop_analyze.c: In function ‘try_find_trip_count_vars_in_iand’: ../src/compiler/nir/nir_loop_analyze.c:846:29: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses] if (*ind ==