Re: [Mesa-dev] [PATCH] nir: remove duplicate Makefile.sources

2016-04-08 Thread Rob Clark
On Fri, Apr 8, 2016 at 4:37 AM, Jose Fonseca wrote: > On 02/04/16 19:35, Rob Clark wrote: >> >> From: Rob Clark >> >> Allegedly this was needed still by scons build.. but in practice it >> doesn't seem to be needed. Removing it and running 'scons' results >> in no build errors. >> >> Signed-off-

Re: [Mesa-dev] [PATCH] nir: remove duplicate Makefile.sources

2016-04-08 Thread Rob Clark
On Fri, Apr 8, 2016 at 4:37 AM, Jose Fonseca wrote: > On 02/04/16 19:35, Rob Clark wrote: >> >> From: Rob Clark >> >> Allegedly this was needed still by scons build.. but in practice it >> doesn't seem to be needed. Removing it and running 'scons' results >> in no build errors. >> >> Signed-off-

Re: [Mesa-dev] [PATCH] nir: remove duplicate Makefile.sources

2016-04-08 Thread Jose Fonseca
On 02/04/16 19:35, Rob Clark wrote: From: Rob Clark Allegedly this was needed still by scons build.. but in practice it doesn't seem to be needed. Removing it and running 'scons' results in no build errors. Signed-off-by: Rob Clark --- So, afaict NIR is not even built w/ scons build (I'm jus

Re: [Mesa-dev] [PATCH] nir: remove duplicate Makefile.sources

2016-04-02 Thread Rob Clark
On Sat, Apr 2, 2016 at 4:33 PM, Rob Clark wrote: > On Sat, Apr 2, 2016 at 4:14 PM, Jason Ekstrand wrote: >> On Sat, Apr 2, 2016 at 11:35 AM, Rob Clark wrote: >>> >>> From: Rob Clark >>> >>> Allegedly this was needed still by scons build.. but in practice it >>> doesn't seem to be needed. Remov

Re: [Mesa-dev] [PATCH] nir: remove duplicate Makefile.sources

2016-04-02 Thread Rob Clark
On Sat, Apr 2, 2016 at 4:14 PM, Jason Ekstrand wrote: > On Sat, Apr 2, 2016 at 11:35 AM, Rob Clark wrote: >> >> From: Rob Clark >> >> Allegedly this was needed still by scons build.. but in practice it >> doesn't seem to be needed. Removing it and running 'scons' results >> in no build errors.

Re: [Mesa-dev] [PATCH] nir: remove duplicate Makefile.sources

2016-04-02 Thread Jason Ekstrand
On Sat, Apr 2, 2016 at 11:35 AM, Rob Clark wrote: > From: Rob Clark > > Allegedly this was needed still by scons build.. but in practice it > doesn't seem to be needed. Removing it and running 'scons' results > in no build errors. > Hrm... I'm not 100% sure what I'd like to see done here. One

[Mesa-dev] [PATCH] nir: remove duplicate Makefile.sources

2016-04-02 Thread Rob Clark
From: Rob Clark Allegedly this was needed still by scons build.. but in practice it doesn't seem to be needed. Removing it and running 'scons' results in no build errors. Signed-off-by: Rob Clark --- So, afaict NIR is not even built w/ scons build (I'm just running 'scons' with no args, so let