Re: [Mesa-dev] [PATCH] nir: fix packing components with arrays

2019-04-15 Thread Samuel Pitoiset
On 4/15/19 10:55 AM, Timothy Arceri wrote: On 15/4/19 5:53 pm, Samuel Pitoiset wrote: Shouldn't we also apply that fix in gather_varying_component_info() ? No because we don't enter that code path for arrays because we don't try to pack arrays into other slots/components. But we do pack sca

Re: [Mesa-dev] [PATCH] nir: fix packing components with arrays

2019-04-15 Thread Timothy Arceri
On 15/4/19 5:53 pm, Samuel Pitoiset wrote: Shouldn't we also apply that fix in gather_varying_component_info() ? No because we don't enter that code path for arrays because we don't try to pack arrays into other slots/components. But we do pack scalar components with "unmovable" arrays when

Re: [Mesa-dev] [PATCH] nir: fix packing components with arrays

2019-04-15 Thread Samuel Pitoiset
Shouldn't we also apply that fix in gather_varying_component_info() ? On 4/15/19 7:00 AM, Timothy Arceri wrote: When gathering info for unmovable types we need to handle arrays. While we dont support packing/moving arrays we do support packing scalar components with these arrays. Fixes piglit:

[Mesa-dev] [PATCH] nir: fix packing components with arrays

2019-04-14 Thread Timothy Arceri
When gathering info for unmovable types we need to handle arrays. While we dont support packing/moving arrays we do support packing scalar components with these arrays. Fixes piglit: tests/spec/arb_enhanced_layouts/execution/component-layout/vs-fs-array-interleave-range.shader_test Fixes: 5eb1750