Re: [Mesa-dev] [PATCH] nir: fix loop iteration count calculation for floats

2017-01-04 Thread Timothy Arceri
On Wed, 2017-01-04 at 06:50 -0800, Jason Ekstrand wrote: > On Jan 4, 2017 4:39 AM, "Eero Tamminen" > wrote: > Hi, > > Tested-by: Eero Tamminen > > May also impact other programs having float indexed loops: > - Invisible Inc > - Talos Principle > > I think I saw most Talos loops get unrolled. 

Re: [Mesa-dev] [PATCH] nir: fix loop iteration count calculation for floats

2017-01-04 Thread Jason Ekstrand
On Jan 4, 2017 4:39 AM, "Eero Tamminen" wrote: Hi, Tested-by: Eero Tamminen May also impact other programs having float indexed loops: - Invisible Inc - Talos Principle I think I saw most Talos loops get unrolled. There was one or two that didn't but I think that was because they had a *lot

Re: [Mesa-dev] [PATCH] nir: fix loop iteration count calculation for floats

2017-01-04 Thread Eero Tamminen
Hi, Tested-by: Eero Tamminen May also impact other programs having float indexed loops: - Invisible Inc - Talos Principle - Steam Big Picture - Serious Sam 3 - Eero On 04.01.2017 02:59, Timothy Arceri wrote: Fixes performance regression in SynMark PSPom caused by loops with float co

Re: [Mesa-dev] [PATCH] nir: fix loop iteration count calculation for floats

2017-01-03 Thread Jason Ekstrand
Drp... Reviewed-by: Jason Ekstrand On Jan 3, 2017 7:00 PM, "Timothy Arceri" wrote: > Fixes performance regression in SynMark PSPom caused by loops with float > counters not always unrolling. > > For example: > >for (float i = 0.02; i < 0.9; i += 0.11) > ... > --- > src/compiler/nir/

[Mesa-dev] [PATCH] nir: fix loop iteration count calculation for floats

2017-01-03 Thread Timothy Arceri
Fixes performance regression in SynMark PSPom caused by loops with float counters not always unrolling. For example: for (float i = 0.02; i < 0.9; i += 0.11) ... --- src/compiler/nir/nir_loop_analyze.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/