Re: [Mesa-dev] [PATCH] nir: drop assert for new arrays code.

2016-05-19 Thread Jason Ekstrand
On Thu, May 19, 2016 at 8:48 PM, Dave Airlie wrote: > From: Dave Airlie > > This code handles 0 length fine, Um... No it doesn't. A length of 0 means unsized which means we really need to to a get_array_length call and loop. Am I messing something? > and with the new glsl layer > code to h

[Mesa-dev] [PATCH] nir: drop assert for new arrays code.

2016-05-19 Thread Dave Airlie
From: Dave Airlie This code handles 0 length fine, and with the new glsl layer code to handle unsized array better, we can hit this path with ./bin/arb_separate_shader_object-GetProgramPipelineiv removing the assert works fine. Signed-off-by: Dave Airlie --- src/compiler/nir/nir_lower_var_cop