Re: [Mesa-dev] [PATCH] nir: add unsigned less then comparison simplification

2018-05-31 Thread Timothy Arceri
On 01/06/18 02:40, Ian Romanick wrote: On 05/30/2018 07:09 PM, Timothy Arceri wrote: On 31/05/18 11:33, Ian Romanick wrote: "less than" whoops ... luckly I removed that bit from the description before pushing This regression is with  "nir: implement the GLSL equivalent of if simplication

Re: [Mesa-dev] [PATCH] nir: add unsigned less then comparison simplification

2018-05-31 Thread Ian Romanick
On 05/30/2018 07:09 PM, Timothy Arceri wrote: > On 31/05/18 11:33, Ian Romanick wrote: >> "less than" > > whoops ... luckly I removed that bit from the description before pushing > >> >> This regression is with  "nir: implement the GLSL equivalent of if >> simplication in nir_opt_if"?  I'll check

Re: [Mesa-dev] [PATCH] nir: add unsigned less then comparison simplification

2018-05-30 Thread Timothy Arceri
On 31/05/18 11:33, Ian Romanick wrote: "less than" whoops ... luckly I removed that bit from the description before pushing This regression is with "nir: implement the GLSL equivalent of if simplication in nir_opt_if"? I'll check to see if this helps the issues that I'm seeing with that

Re: [Mesa-dev] [PATCH] nir: add unsigned less then comparison simplification

2018-05-30 Thread Ian Romanick
"less than" This regression is with "nir: implement the GLSL equivalent of if simplication in nir_opt_if"? I'll check to see if this helps the issues that I'm seeing with that patch... On 05/30/2018 04:09 AM, Timothy Arceri wrote: > This avoids loop unrolling regressions in Wolfenstein II on DX

Re: [Mesa-dev] [PATCH] nir: add unsigned less then comparison simplification

2018-05-30 Thread Bas Nieuwenhuizen
On Wed, May 30, 2018 at 1:09 PM, Timothy Arceri wrote: > This avoids loop unrolling regressions in Wolfenstein II on DXVK > with an upcoming optimisation series from Samuel. > --- > src/compiler/nir/nir_opt_algebraic.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/compiler/nir/nir

[Mesa-dev] [PATCH] nir: add unsigned less then comparison simplification

2018-05-30 Thread Timothy Arceri
This avoids loop unrolling regressions in Wolfenstein II on DXVK with an upcoming optimisation series from Samuel. --- src/compiler/nir/nir_opt_algebraic.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index 909e