Re: [Mesa-dev] [PATCH] nir: add some comparison simplifications

2018-03-16 Thread Timothy Arceri
Ok feel free to push your patch with : Reviewed-by: Timothy Arceri On 17/03/18 02:19, Ian Romanick wrote: On 03/16/2018 07:37 AM, Ian Romanick wrote: I have basically the same patch setting in my simple-range-analysis tree. https://cgit.freedesktop.org/~idr/mesa/commit/?h=simple-range-analys

Re: [Mesa-dev] [PATCH] nir: add some comparison simplifications

2018-03-16 Thread Ian Romanick
On 03/16/2018 07:37 AM, Ian Romanick wrote: > I have basically the same patch setting in my simple-range-analysis tree. > > https://cgit.freedesktop.org/~idr/mesa/commit/?h=simple-range-analysis&id=e9d29d71304347f8ff904294450a398e5838f49a > > As Jason mentions, you don't need to explicitly mentio

Re: [Mesa-dev] [PATCH] nir: add some comparison simplifications

2018-03-16 Thread Ian Romanick
I have basically the same patch setting in my simple-range-analysis tree. https://cgit.freedesktop.org/~idr/mesa/commit/?h=simple-range-analysis&id=e9d29d71304347f8ff904294450a398e5838f49a As Jason mentions, you don't need to explicitly mention the compares. You don't need the @bool either... the

Re: [Mesa-dev] [PATCH] nir: add some comparison simplifications

2018-03-15 Thread Jason Ekstrand
I think you can just do (('ine', ('b2i', 'a@bool'), 0), 'a'), Or something like that. I may have gotten the syntax wrong. On March 15, 2018 20:53:44 Timothy Arceri wrote: These can be found in the Tomb Raider shaders, eliminating them helps unroll more loops. --- src/compiler/nir/nir_opt

[Mesa-dev] [PATCH] nir: add some comparison simplifications

2018-03-15 Thread Timothy Arceri
These can be found in the Tomb Raider shaders, eliminating them helps unroll more loops. --- src/compiler/nir/nir_opt_algebraic.py | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index c9575e6be4..56dfc53043 100