Re: [Mesa-dev] [PATCH] nir: add helper to get # of dest components

2015-04-27 Thread Connor Abbott
When you push this, can you make sure there are users for it so it isn't just dead code? Either in your driver, or there are probably several places in core NIR where we currently open-code this. Otherwise, Reviewed-by: Connor Abbott On Mon, Apr 27, 2015 at 3:05 PM, Rob Clark wrote: > From: Rob

Re: [Mesa-dev] [PATCH] nir: add helper to get # of dest components

2015-04-27 Thread Rob Clark
yeah, I'll probably end up pushing it together w/ freedreno/ir3 patches using it.. but that is a good point about garbage collecting existing open-coded versions of this.. I guess I should do that anyways. BR, -R On Mon, Apr 27, 2015 at 3:11 PM, Connor Abbott wrote: > When you push this, can y

[Mesa-dev] [PATCH] nir: add helper to get # of dest components

2015-04-27 Thread Rob Clark
From: Rob Clark I need something like this in a couple places. And didn't see anything like it anywhere. Signed-off-by: Rob Clark --- src/glsl/nir/nir.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index 98b0ec3..3a96d56 100644 --- a/src