Re: [Mesa-dev] [PATCH] nir: Fix logic error.

2015-02-09 Thread Matt Turner
On Mon, Feb 9, 2015 at 2:06 PM, Jason Ekstrand wrote: > Wow... I need to learn to read... I think we actually want || and ==. Feel free to take it over. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listin

Re: [Mesa-dev] [PATCH] nir: Fix logic error.

2015-02-09 Thread Jason Ekstrand
On Mon, Feb 9, 2015 at 4:54 PM, Matt Turner wrote: > On Mon, Feb 9, 2015 at 1:45 PM, Jason Ekstrand > wrote: > > Sorry I didn't get to this earlier. It got lost in the backlog. > > > > Reviewed-by: Jason Ekstrand > > > > Out of curiosity, are there any shader-db results for this? If not, > th

Re: [Mesa-dev] [PATCH] nir: Fix logic error.

2015-02-09 Thread Matt Turner
On Mon, Feb 9, 2015 at 1:45 PM, Jason Ekstrand wrote: > Sorry I didn't get to this earlier. It got lost in the backlog. > > Reviewed-by: Jason Ekstrand > > Out of curiosity, are there any shader-db results for this? If not, that's > ok. I didn't even know if this the correct fix, so no shader-

Re: [Mesa-dev] [PATCH] nir: Fix logic error.

2015-02-09 Thread Jason Ekstrand
Sorry I didn't get to this earlier. It got lost in the backlog. Reviewed-by: Jason Ekstrand Out of curiosity, are there any shader-db results for this? If not, that's ok. --Jason On Wed, Feb 4, 2015 at 3:19 PM, Matt Turner wrote: > --- > I don't know if this is right, but what we had befor

[Mesa-dev] [PATCH] nir: Fix logic error.

2015-02-04 Thread Matt Turner
--- I don't know if this is right, but what we had before was definitely wrong. (And gcc warned about it!) src/glsl/nir/nir_lower_phis_to_scalar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/nir/nir_lower_phis_to_scalar.c b/src/glsl/nir/nir_lower_phis_to_sc