Re: [Mesa-dev] [PATCH] nir: Divergence Analysis

2018-10-26 Thread Daniel Schürmann
Hi Ian, thank you very much for the detailed suggestions. I added the formatting to adhere the coding conventions. Please remind that this is an RFC, not a pull request. The implementation is incomplete and not meant to go upstream in this state. And while I added some, there are still a lot of

Re: [Mesa-dev] [PATCH] nir: Divergence Analysis

2018-10-25 Thread Ian Romanick
I'm going to try to review this more thoroughly for content later. For now, I'm going to send a bunch of notes about formatting / Mesa coding conventions. On 10/08/2018 04:04 AM, Daniel Schürmann wrote: > --- > src/compiler/nir/meson.build | 1 + > src/compiler/nir/nir.h

Re: [Mesa-dev] [PATCH] nir: Divergence Analysis

2018-10-24 Thread andrey simiklit
Hello, Please find my comment below: On Mon, Oct 8, 2018 at 2:15 PM Daniel Schürmann < daniel.schuerm...@campus.tu-berlin.de> wrote: > --- > src/compiler/nir/meson.build | 1 + > src/compiler/nir/nir.h | 2 + > src/compiler/nir/nir_divergence_analysis.c | 3

[Mesa-dev] [PATCH] nir: Divergence Analysis

2018-10-08 Thread Daniel Schürmann
--- src/compiler/nir/meson.build | 1 + src/compiler/nir/nir.h | 2 + src/compiler/nir/nir_divergence_analysis.c | 333 + 3 files changed, 336 insertions(+) create mode 100644 src/compiler/nir/nir_divergence_analysis.c diff --git a/src/co