Re: [Mesa-dev] [PATCH] nir: Add variants of some of the comparison simplifications.

2015-01-29 Thread Jason Ekstrand
On Wed, Jan 28, 2015 at 11:20 PM, Eric Anholt wrote: > Jason Ekstrand writes: > > > I've got a patch I cooked up today that generalizes this a bit. I > haven't > > sent it yet because it lacks shader-db statistics. That said, I'm fine > > with merging this in the mean time. > > Not sure what g

Re: [Mesa-dev] [PATCH] nir: Add variants of some of the comparison simplifications.

2015-01-28 Thread Eric Anholt
Jason Ekstrand writes: > I've got a patch I cooked up today that generalizes this a bit. I haven't > sent it yet because it lacks shader-db statistics. That said, I'm fine > with merging this in the mean time. Not sure what generalization you're working on, but something that let me have "any

Re: [Mesa-dev] [PATCH] nir: Add variants of some of the comparison simplifications.

2015-01-28 Thread Jason Ekstrand
I've got a patch I cooked up today that generalizes this a bit. I haven't sent it yet because it lacks shader-db statistics. That said, I'm fine with merging this in the mean time. --Jason On Wed, Jan 28, 2015 at 5:48 PM, Matt Turner wrote: > Reviewed-by: Matt Turner > ___

Re: [Mesa-dev] [PATCH] nir: Add variants of some of the comparison simplifications.

2015-01-28 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] nir: Add variants of some of the comparison simplifications.

2015-01-28 Thread Eric Anholt
We end up with these from TGSI-to-NIR because the pass generating the comparisons doesn't know if the arg is actually a bool input or not. total instructions in shared programs: 41801 -> 41508 (-0.70%) instructions in affected programs: 4253 -> 3960 (-6.89%) --- src/glsl/nir/nir_opt_algebraic