Re: [Mesa-dev] [PATCH] nir/spirv: tg4 requires a sampler

2017-11-07 Thread Alex Smith
Good point :) Will do soon. On 7 November 2017 at 15:46, Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > > Given that you already have 27 non-trivial commits in mesa, I think now > would be a good time to apply for commit access. :-) > > On Tue, Nov 7, 2017 at 2:52 AM, Alex Smith > wrot

Re: [Mesa-dev] [PATCH] nir/spirv: tg4 requires a sampler

2017-11-07 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand Given that you already have 27 non-trivial commits in mesa, I think now would be a good time to apply for commit access. :-) On Tue, Nov 7, 2017 at 2:52 AM, Alex Smith wrote: > Gather operations in both GLSL and SPIR-V require a sampler. Fixes > gathers returning g

[Mesa-dev] [PATCH] nir/spirv: tg4 requires a sampler

2017-11-07 Thread Alex Smith
Gather operations in both GLSL and SPIR-V require a sampler. Fixes gathers returning garbage when using separate texture/samplers (on AMD, was using an invalid sampler descriptor). Signed-off-by: Alex Smith Cc: "17.2 17.3" --- src/compiler/nir/nir.h| 1 - src/compiler/spirv/spirv_to