Re: [Mesa-dev] [PATCH] nir/opcodes: Fix constant-folding of ufind_msb

2017-08-28 Thread Connor Abbott
Reviewed-by: Connor Abbott On Aug 28, 2017 11:11 PM, "Jason Ekstrand" wrote: > We didn't fold correctly in the case of 0x1 because we never let the > loop counter hit 0. Switching it to bit >= 0 solves this problem. > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/compiler/nir/nir_opcode

Re: [Mesa-dev] [PATCH] nir/opcodes: Fix constant-folding of ufind_msb

2017-08-28 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Tue, Aug 29, 2017, at 00:10, Jason Ekstrand wrote: > We didn't fold correctly in the case of 0x1 because we never let the > loop counter hit 0. Switching it to bit >= 0 solves this problem. > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/compiler/nir/nir

[Mesa-dev] [PATCH] nir/opcodes: Fix constant-folding of ufind_msb

2017-08-28 Thread Jason Ekstrand
We didn't fold correctly in the case of 0x1 because we never let the loop counter hit 0. Switching it to bit >= 0 solves this problem. Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/nir/nir_opcodes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/ni