Re: [Mesa-dev] [PATCH] nir/gcm: fix a bug with metadata handling

2017-01-14 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Sat, Jan 14, 2017 at 3:12 PM, Connor Abbott wrote: > We were using impl->num_blocks, but that isn't guaranteed to be > up-to-date until after the block_index metadata is required. If we were > unlucky, this could lead to overwriting memory. > > Noticed by inspecti

[Mesa-dev] [PATCH] nir/gcm: fix a bug with metadata handling

2017-01-14 Thread Connor Abbott
We were using impl->num_blocks, but that isn't guaranteed to be up-to-date until after the block_index metadata is required. If we were unlucky, this could lead to overwriting memory. Noticed by inspection. Signed-off-by: Connor Abbott --- src/compiler/nir/nir_opt_gcm.c | 6 +++--- 1 file chang