Re: [Mesa-dev] [PATCH] nir/gather_info: Handle double inputs in set_io_mask

2017-12-02 Thread Jason Ekstrand
Ugh... This patch, though obviously correct if taken on its own, doesn't wok. The double_inputs_read field is more subtle and bonkers than I thought. On Sat, Dec 2, 2017 at 9:32 AM, Jason Ekstrand wrote: > It's a little sketchy to put the logic in set_io_mask but due to a > detail of the GLSL s

[Mesa-dev] [PATCH] nir/gather_info: Handle double inputs in set_io_mask

2017-12-02 Thread Jason Ekstrand
It's a little sketchy to put the logic in set_io_mask but due to a detail of the GLSL spec, it's safe to check for 64-bit without knowing the full access chain. This fixes a bug where try_mask_partial_io succeeded at marking a portion of the input as used but then we came along and marked the whol