Re: [Mesa-dev] [PATCH] nir/cse: fix bug with comparing non-per-component sources

2015-04-14 Thread Jason Ekstrand
On Tue, Apr 14, 2015 at 2:00 PM, Connor Abbott wrote: > On Tue, Apr 14, 2015 at 4:56 PM, Jason Ekstrand wrote: >> On Tue, Apr 14, 2015 at 1:39 PM, Connor Abbott wrote: >>> On Tue, Apr 14, 2015 at 3:55 PM, Jason Ekstrand wrote: On Tue, Apr 14, 2015 at 12:51 PM, Connor Abbott wrote: > W

Re: [Mesa-dev] [PATCH] nir/cse: fix bug with comparing non-per-component sources

2015-04-14 Thread Connor Abbott
On Tue, Apr 14, 2015 at 4:56 PM, Jason Ekstrand wrote: > On Tue, Apr 14, 2015 at 1:39 PM, Connor Abbott wrote: >> On Tue, Apr 14, 2015 at 3:55 PM, Jason Ekstrand wrote: >>> On Tue, Apr 14, 2015 at 12:51 PM, Connor Abbott wrote: We weren't comparing the right number of components when check

Re: [Mesa-dev] [PATCH] nir/cse: fix bug with comparing non-per-component sources

2015-04-14 Thread Jason Ekstrand
On Tue, Apr 14, 2015 at 1:39 PM, Connor Abbott wrote: > On Tue, Apr 14, 2015 at 3:55 PM, Jason Ekstrand wrote: >> On Tue, Apr 14, 2015 at 12:51 PM, Connor Abbott wrote: >>> We weren't comparing the right number of components when checking >>> swizzles. Use nir_ssa_alu_instr_num_src_components()

Re: [Mesa-dev] [PATCH] nir/cse: fix bug with comparing non-per-component sources

2015-04-14 Thread Connor Abbott
On Tue, Apr 14, 2015 at 3:55 PM, Jason Ekstrand wrote: > On Tue, Apr 14, 2015 at 12:51 PM, Connor Abbott wrote: >> We weren't comparing the right number of components when checking >> swizzles. Use nir_ssa_alu_instr_num_src_components() to do the right > > I don't like the name of that function,

Re: [Mesa-dev] [PATCH] nir/cse: fix bug with comparing non-per-component sources

2015-04-14 Thread Ian Romanick
Reviewed-by: Ian Romanick As soon as it lands, I'll rebase and push my patch. On 04/14/2015 12:51 PM, Connor Abbott wrote: > We weren't comparing the right number of components when checking > swizzles. Use nir_ssa_alu_instr_num_src_components() to do the right > thing. > > I haven't piglited t

Re: [Mesa-dev] [PATCH] nir/cse: fix bug with comparing non-per-component sources

2015-04-14 Thread Jason Ekstrand
On Tue, Apr 14, 2015 at 12:51 PM, Connor Abbott wrote: > We weren't comparing the right number of components when checking > swizzles. Use nir_ssa_alu_instr_num_src_components() to do the right I don't like the name of that function, but oh well. Reviewed-by: Jason Ekstrand > thing. > > I have

[Mesa-dev] [PATCH] nir/cse: fix bug with comparing non-per-component sources

2015-04-14 Thread Connor Abbott
We weren't comparing the right number of components when checking swizzles. Use nir_ssa_alu_instr_num_src_components() to do the right thing. I haven't piglited this yet, but it seems straightforward. Cc: Ian Romanick Signed-off-by: Connor Abbott --- src/glsl/nir/nir_opt_cse.c | 17 +++