Re: [Mesa-dev] [PATCH] nir,ac/nir: fix cube_face_coord

2019-04-12 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 4/12/19 12:15 PM, Rhys Perry wrote: Seems it was missing the "/ ma + 0.5" and the order was swapped. Fixes: a1a2a8dfda7b9cac7e ('nir: add AMD_gcn_shader extended instructions') Signed-off-by: Rhys Perry --- src/amd/common/ac_nir_to_llvm.c | 11 +-- s

[Mesa-dev] [PATCH] nir,ac/nir: fix cube_face_coord

2019-04-12 Thread Rhys Perry
Seems it was missing the "/ ma + 0.5" and the order was swapped. Fixes: a1a2a8dfda7b9cac7e ('nir: add AMD_gcn_shader extended instructions') Signed-off-by: Rhys Perry --- src/amd/common/ac_nir_to_llvm.c | 11 +-- src/compiler/nir/nir_opcodes.py | 21 +++-- 2 files changed