Re: [Mesa-dev] [PATCH] nicer-no-wrap-patch

2013-11-12 Thread Eric Anholt
"Rogovin, Kevin" writes: > Hi all, I will later submit a patch taking into account comments, however one > comment I will address *now*. > > Eric Anholt [e...@anholt.net] writes: > >>Kevin Rogovin writes: >> >>> This patch adds a function interface for enabling no wrap on batch commands, >>>add

Re: [Mesa-dev] [PATCH] nicer-no-wrap-patch

2013-11-11 Thread Rogovin, Kevin
2nd dry was recorded as sent after the correct run. If people want, I can send it out again with a different subject, but the details of the message are: http://lists.freedesktop.org/archives/mesa-dev/2013-November/048257.html [Mesa-dev] [PATCH] nicer-no-wrap-patch Kevin Rogovin kevin.rogovin

[Mesa-dev] [PATCH] nicer-no-wrap-patch

2013-11-11 Thread Kevin Rogovin
Track bytes written during no flush phases for debug builds --- src/mesa/drivers/dri/i965/brw_context.h | 85 +++ src/mesa/drivers/dri/i965/brw_draw.c | 4 +- src/mesa/drivers/dri/i965/brw_state_batch.c | 15 + src/mesa/drivers/dri/i965/intel_batchb

[Mesa-dev] [PATCH] nicer-no-wrap-patch

2013-11-11 Thread Kevin Rogovin
feedback integrated space-pace --- src/mesa/drivers/dri/i965/brw_context.h | 85 +++ src/mesa/drivers/dri/i965/brw_draw.c | 4 +- src/mesa/drivers/dri/i965/brw_state_batch.c | 15 + src/mesa/drivers/dri/i965/intel_batchbuffer.h | 6 ++ 4 files change

[Mesa-dev] [PATCH] nicer-no-wrap-patch

2013-11-11 Thread Kevin Rogovin
feedback integrated space-pace --- src/mesa/drivers/dri/i965/brw_context.h | 85 +++ src/mesa/drivers/dri/i965/brw_draw.c | 4 +- src/mesa/drivers/dri/i965/brw_state_batch.c | 15 + src/mesa/drivers/dri/i965/intel_batchbuffer.h | 6 ++ 4 files change

Re: [Mesa-dev] [PATCH] nicer-no-wrap-patch

2013-11-11 Thread Rogovin, Kevin
ktop.org Cc: Rogovin, Kevin Subject: Re: [Mesa-dev] [PATCH] nicer-no-wrap-patch Kevin Rogovin writes: > This patch adds a function interface for enabling no wrap on batch commands, > adds to it assert enforcement that the number bytes added to the > batch buffer does not exceed a passed value

Re: [Mesa-dev] [PATCH] nicer-no-wrap-patch

2013-11-11 Thread Eric Anholt
Kevin Rogovin writes: > This patch adds a function interface for enabling no wrap on batch commands, > adds to it assert enforcement that the number bytes added to the > batch buffer does not exceed a passed value and finally this is used > in brw_try_draw_prims() to help make sure that estimated

Re: [Mesa-dev] [PATCH] nicer-no-wrap-patch

2013-11-11 Thread Ian Romanick
On 11/11/2013 01:35 AM, Kevin Rogovin wrote: > This patch adds a function interface for enabling no wrap on batch commands, > adds to it assert enforcement that the number bytes added to the > batch buffer does not exceed a passed value and finally this is used > in brw_try_draw_prims() to help mak

Re: [Mesa-dev] [PATCH] nicer-no-wrap-patch

2013-11-11 Thread Matt Turner
Need a better commit message. I like the kernel's guidelines which remind us that the summary becomes the globally-unique identifier for the patch. Style comments: On Mon, Nov 11, 2013 at 1:35 AM, Kevin Rogovin wrote: > This patch adds a function interface for enabling no wrap on batch commands,

[Mesa-dev] [PATCH] nicer-no-wrap-patch

2013-11-11 Thread Kevin Rogovin
This patch adds a function interface for enabling no wrap on batch commands, adds to it assert enforcement that the number bytes added to the batch buffer does not exceed a passed value and finally this is used in brw_try_draw_prims() to help make sure that estimated_max_prim_size is a good value.