Re: [Mesa-dev] [PATCH] meta: save and restore swizzle for _GenerateMipmap

2014-06-11 Thread Robert Bragg
On Tue, Jun 10, 2014 at 6:00 PM, Ian Romanick wrote: > On 06/09/2014 07:48 AM, Robert Bragg wrote: >> This makes sure to use a no-op swizzle while iteratively rendering each >> level of a mipmap otherwise we may loose components and effectively >> apply the swizzle twice by the time these levels a

Re: [Mesa-dev] [PATCH] meta: save and restore swizzle for _GenerateMipmap

2014-06-10 Thread Ian Romanick
On 06/09/2014 07:48 AM, Robert Bragg wrote: > This makes sure to use a no-op swizzle while iteratively rendering each > level of a mipmap otherwise we may loose components and effectively > apply the swizzle twice by the time these levels are sampled. Right... the swizzle state shouldn't affect mi

Re: [Mesa-dev] [PATCH] meta: save and restore swizzle for _GenerateMipmap

2014-06-09 Thread Chris Forbes
It would be good to have a piglit test which demonstrates the need for this. Reviewed-by: Chris Forbes On Tue, Jun 10, 2014 at 2:48 AM, Robert Bragg wrote: > This makes sure to use a no-op swizzle while iteratively rendering each > level of a mipmap otherwise we may loose components and effecti

[Mesa-dev] [PATCH] meta: save and restore swizzle for _GenerateMipmap

2014-06-09 Thread Robert Bragg
This makes sure to use a no-op swizzle while iteratively rendering each level of a mipmap otherwise we may loose components and effectively apply the swizzle twice by the time these levels are sampled. --- src/mesa/drivers/common/meta_generate_mipmap.c | 12 1 file changed, 12 inserti