Re: [Mesa-dev] [PATCH] meta: Remove dither bit from blit paths that do not need it

2014-08-04 Thread Neil Roberts
I'm not sure about either of these patches. It looks like according to the GL 4.4 spec dithering is not supposed to affect glBlitFramebuffer: “When values are written to the draw buffers, blit operations bypass most of the fragment pipeline. The only fragment operations which affect a blit are t

Re: [Mesa-dev] [PATCH] meta: Remove dither bit from blit paths that do not need it

2014-08-04 Thread Pohjolainen, Topi
On Sun, Aug 03, 2014 at 06:32:54PM -0700, Kenneth Graunke wrote: > On Friday, August 01, 2014 08:37:53 PM Topi Pohjolainen wrote: > > Similarly to an older patch. This is the minimum needed to fix the > > bug but there are other meta-paths remaining that have the bit > > since its introduction but

Re: [Mesa-dev] [PATCH] meta: Remove dither bit from blit paths that do not need it

2014-08-03 Thread Kenneth Graunke
On Friday, August 01, 2014 08:37:53 PM Topi Pohjolainen wrote: > Similarly to an older patch. This is the minimum needed to fix the > bug but there are other meta-paths remaining that have the bit > since its introduction but not before. Why not just drop the _mesa_set_enable(ctx, GL_DITHER, G

[Mesa-dev] [PATCH] meta: Remove dither bit from blit paths that do not need it

2014-08-01 Thread Topi Pohjolainen
Similarly to an older patch. This is the minimum needed to fix the bug but there are other meta-paths remaining that have the bit since its introduction but not before. commit e526ebf35c113d59eb0b860e492c1308d3862ee9 Author: Kenneth Graunke Date: Mon May 5 14:03:46 2014 -0700 meta: Add a n