Re: [Mesa-dev] [PATCH] meta: Don't _mesa_set_enable() invalid targets in ES 1.

2012-09-15 Thread Kenneth Graunke
On 09/14/2012 11:23 PM, Ian Romanick wrote: > On 09/14/2012 01:01 PM, Kenneth Graunke wrote: >> GL_TEXTURE_1D, GL_TEXTURE_RECTANGLE, and GL_TEXTURE_GEN_* don't exist in >> ES 1 contexts, so any meta ops that used _mesa_meta_begin with >> MESA_META_TEXTURE would trigger GL errors. One such operatio

Re: [Mesa-dev] [PATCH] meta: Don't _mesa_set_enable() invalid targets in ES 1.

2012-09-14 Thread Ian Romanick
On 09/14/2012 01:01 PM, Kenneth Graunke wrote: GL_TEXTURE_1D, GL_TEXTURE_RECTANGLE, and GL_TEXTURE_GEN_* don't exist in ES 1 contexts, so any meta ops that used _mesa_meta_begin with MESA_META_TEXTURE would trigger GL errors. One such operation is _mesa_meta_Clear(). Fixes the ES1 conformance t

Re: [Mesa-dev] [PATCH] meta: Don't _mesa_set_enable() invalid targets in ES 1.

2012-09-14 Thread Kenneth Graunke
On 09/14/2012 06:05 AM, Brian Paul wrote: > On 09/14/2012 04:01 AM, Kenneth Graunke wrote: >> GL_TEXTURE_1D, GL_TEXTURE_RECTANGLE, and GL_TEXTURE_GEN_* don't exist in >> ES 1 contexts, so any meta ops that used _mesa_meta_begin with >> MESA_META_TEXTURE would trigger GL errors. One such operation

Re: [Mesa-dev] [PATCH] meta: Don't _mesa_set_enable() invalid targets in ES 1.

2012-09-14 Thread Brian Paul
On 09/14/2012 04:01 AM, Kenneth Graunke wrote: GL_TEXTURE_1D, GL_TEXTURE_RECTANGLE, and GL_TEXTURE_GEN_* don't exist in ES 1 contexts, so any meta ops that used _mesa_meta_begin with MESA_META_TEXTURE would trigger GL errors. One such operation is _mesa_meta_Clear(). Fixes the ES1 conformance t

[Mesa-dev] [PATCH] meta: Don't _mesa_set_enable() invalid targets in ES 1.

2012-09-14 Thread Kenneth Graunke
GL_TEXTURE_1D, GL_TEXTURE_RECTANGLE, and GL_TEXTURE_GEN_* don't exist in ES 1 contexts, so any meta ops that used _mesa_meta_begin with MESA_META_TEXTURE would trigger GL errors. One such operation is _mesa_meta_Clear(). Fixes the ES1 conformance test miplin.c, which was regressed by commit 08be1