On Tue, Apr 15, 2014 at 7:15 PM, Chris Forbes wrote:
> Fixes piglit's fbo-blit-stretch test on drivers which use the meta path.
> (i965: should fix Broadwell, but also fixes Sandybridge/Ivybridge/Haswell
> since this test falls off the blorp path now due to format conversion)
>
> V2: Use scissor i
Fixes piglit's fbo-blit-stretch test on drivers which use the meta path.
(i965: should fix Broadwell, but also fixes Sandybridge/Ivybridge/Haswell
since this test falls off the blorp path now due to format conversion)
V2: Use scissor instead of just mangling the rects, to avoid texcoord
rounding p
Right, that makes good sense.
On Mon, Apr 14, 2014 at 11:28 PM, Marek Olšák wrote:
> For scaled blits, this is not correct. For example, if you blit a
> 10x10 texture to another 10x10 texture with horizontal scaling of
> 1.5x, the X texture coordinate of the rightmost pixel should be
> 6.66.
For scaled blits, this is not correct. For example, if you blit a
10x10 texture to another 10x10 texture with horizontal scaling of
1.5x, the X texture coordinate of the rightmost pixel should be
6.66. Mesa clip blit doesn't return floating-point coordinates of
the source, so you can't use them
Nothing was bothering to clip the blit. If the src rect was partially
outside the framebuffer, we'd end up picking up more copies of the
edge texels due to clamping.
Note that this is slight overkill -- we could get away with clipping src
only, since fragments outside the destination surface will
