Re: [Mesa-dev] [PATCH] mesa: use c99 functions on non-linux platforms if supported

2013-08-25 Thread Chí-Thanh Christopher Nguyễn
Ian Romanick freedesktop.org> writes: > http://herbsutter.com/2012/05/03/reader-qa-what-about-vc-and-c99/ > > It seems that designated initializers may not be supported (ugh), but > most of the "slips" we've had over the years have been > mixed-code-and-declarations. This piece of information

Re: [Mesa-dev] [PATCH] mesa: use c99 functions on non-linux platforms if supported

2013-08-06 Thread Ian Romanick
On 08/05/2013 06:52 PM, Jonathan Gray wrote: On Mon, Aug 05, 2013 at 09:46:58AM -0700, Chad Versace wrote: On 08/01/2013 03:52 PM, Jonathan Gray wrote: On Thu, Aug 01, 2013 at 11:21:57AM -0700, Ian Romanick wrote: On 08/01/2013 09:54 AM, Chad Versace wrote: On 08/01/2013 09:48 AM, Chad Versac

Re: [Mesa-dev] [PATCH] mesa: use c99 functions on non-linux platforms if supported

2013-08-05 Thread Jonathan Gray
On Mon, Aug 05, 2013 at 09:46:58AM -0700, Chad Versace wrote: > On 08/01/2013 03:52 PM, Jonathan Gray wrote: > >On Thu, Aug 01, 2013 at 11:21:57AM -0700, Ian Romanick wrote: > >>On 08/01/2013 09:54 AM, Chad Versace wrote: > >>>On 08/01/2013 09:48 AM, Chad Versace wrote: > On 08/01/2013 12:27 AM

Re: [Mesa-dev] [PATCH] mesa: use c99 functions on non-linux platforms if supported

2013-08-05 Thread Chad Versace
On 08/01/2013 03:52 PM, Jonathan Gray wrote: On Thu, Aug 01, 2013 at 11:21:57AM -0700, Ian Romanick wrote: On 08/01/2013 09:54 AM, Chad Versace wrote: On 08/01/2013 09:48 AM, Chad Versace wrote: On 08/01/2013 12:27 AM, Jonathan Gray wrote: Signed-off-by: Jonathan Gray --- src/mesa/main/imp

Re: [Mesa-dev] [PATCH] mesa: use c99 functions on non-linux platforms if supported

2013-08-01 Thread Jonathan Gray
On Thu, Aug 01, 2013 at 11:21:57AM -0700, Ian Romanick wrote: > On 08/01/2013 09:54 AM, Chad Versace wrote: > >On 08/01/2013 09:48 AM, Chad Versace wrote: > >>On 08/01/2013 12:27 AM, Jonathan Gray wrote: > >>>Signed-off-by: Jonathan Gray > >>>--- > >>> src/mesa/main/imports.h | 2 +- > >>> 1 file

Re: [Mesa-dev] [PATCH] mesa: use c99 functions on non-linux platforms if supported

2013-08-01 Thread Ian Romanick
On 08/01/2013 09:54 AM, Chad Versace wrote: On 08/01/2013 09:48 AM, Chad Versace wrote: On 08/01/2013 12:27 AM, Jonathan Gray wrote: Signed-off-by: Jonathan Gray --- src/mesa/main/imports.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git src/mesa/main/imports.h src/mesa/ma

Re: [Mesa-dev] [PATCH] mesa: use c99 functions on non-linux platforms if supported

2013-08-01 Thread Chad Versace
On 08/01/2013 09:48 AM, Chad Versace wrote: On 08/01/2013 12:27 AM, Jonathan Gray wrote: Signed-off-by: Jonathan Gray --- src/mesa/main/imports.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git src/mesa/main/imports.h src/mesa/main/imports.h index 53e40b4..aa7dc49 100644 --

Re: [Mesa-dev] [PATCH] mesa: use c99 functions on non-linux platforms if supported

2013-08-01 Thread Ian Romanick
Do you have specific platforms in mind? Are these autoconf platforms or scons platforms? If it's the former, I'd rather just use the HAVE_ macros that's standard for autoconf builds. I recall trying to use __STDC_VERSION__ for various things in Mesa in the past, but we found that some platfo

Re: [Mesa-dev] [PATCH] mesa: use c99 functions on non-linux platforms if supported

2013-08-01 Thread Chad Versace
On 08/01/2013 12:27 AM, Jonathan Gray wrote: Signed-off-by: Jonathan Gray --- src/mesa/main/imports.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git src/mesa/main/imports.h src/mesa/main/imports.h index 53e40b4..aa7dc49 100644 --- src/mesa/main/imports.h +++ src/mesa/main/i

[Mesa-dev] [PATCH] mesa: use c99 functions on non-linux platforms if supported

2013-08-01 Thread Jonathan Gray
Signed-off-by: Jonathan Gray --- src/mesa/main/imports.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git src/mesa/main/imports.h src/mesa/main/imports.h index 53e40b4..aa7dc49 100644 --- src/mesa/main/imports.h +++ src/mesa/main/imports.h @@ -230,7 +230,7 @@ static inline int IS