Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-25 Thread Lin, Johnson
Cool. Thanks. Will update the patch. -Original Message- From: Palli, Tapani Sent: Friday, March 23, 2018 4:59 PM To: Lin, Johnson ; Alejandro Piñeiro ; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT On 03/23/2018 07:54 AM

Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-23 Thread Tapani Pälli
; Alejandro Piñeiro ; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT On 03/22/2018 07:53 AM, Tapani Pälli wrote: On 03/22/2018 04:43 AM, Lin, Johnson wrote: Hi,  Thanks for the comments. I just noticed it does not

Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-23 Thread Alejandro Piñeiro
research, how about it we mention it somewhere? In a comment at the code, or perhaps in the commit message is enough. > > >> -Original Message- >> From: Palli, Tapani >> Sent: Friday, March 23, 2018 1:53 PM >> To: Lin, Johnson ; Alejandro Piñeiro >> ; me

Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-23 Thread Tapani Pälli
not enabled and would need more work elsewhere. -Original Message- From: Palli, Tapani Sent: Friday, March 23, 2018 1:53 PM To: Lin, Johnson ; Alejandro Piñeiro ; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT On 03/22/2

Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-22 Thread Lin, Johnson
2018 6:57 PM >> To: Alejandro Piñeiro ; Lin, Johnson >> ; mesa-dev@lists.freedesktop.org >> Subject: Re: [Mesa-dev] [PATCH] mesa: readpixels add support for >> GL_HALF_FLOAT >> >> >> >> On 21.03.2018 12:45, Tapani Pälli wrote: >>>

Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-22 Thread Tapani Pälli
sa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT On 21.03.2018 12:45, Tapani Pälli wrote: On 21.03.2018 08:52, Alejandro Piñeiro wrote: On 21/03/18 06:57, Lin Johnson wrote: Ext_color_buffer_half_float is using type GL_HALF_FLOAT and data_type GL_FLOAT. This

Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-21 Thread Tapani Pälli
org Subject: Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT On 21.03.2018 12:45, Tapani Pälli wrote: On 21.03.2018 08:52, Alejandro Piñeiro wrote: On 21/03/18 06:57, Lin Johnson wrote: Ext_color_buffer_half_float is using type GL_HALF_FLOAT and data_type GL_FLOAT. This fix A

Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-21 Thread Lin, Johnson
: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT On 21.03.2018 12:45, Tapani Pälli wrote: > > > On 21.03.2018 08:52, Alejandro Piñeiro wrote: >> On 21/03/18 06:57, Lin Johnson wrote: >>> Ext_color_buffer_half_float is using type GL_HALF_FLOAT and >>

Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-21 Thread Tapani Pälli
On 21.03.2018 12:45, Tapani Pälli wrote: On 21.03.2018 08:52, Alejandro Piñeiro wrote: On 21/03/18 06:57, Lin Johnson wrote: Ext_color_buffer_half_float is using type GL_HALF_FLOAT and data_type GL_FLOAT. This fix Android CTS test android.view.cts.PixelCopyTest #TestWindowProducerCopyToRG

Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-21 Thread Tapani Pälli
On 21.03.2018 08:52, Alejandro Piñeiro wrote: On 21/03/18 06:57, Lin Johnson wrote: Ext_color_buffer_half_float is using type GL_HALF_FLOAT and data_type GL_FLOAT. This fix Android CTS test android.view.cts.PixelCopyTest #TestWindowProducerCopyToRGBA16F Signed-off-by: Lin Johnson --- src/m

Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-20 Thread Alejandro Piñeiro
On 21/03/18 06:57, Lin Johnson wrote: > Ext_color_buffer_half_float is using type GL_HALF_FLOAT > and data_type GL_FLOAT. This fix Android CTS test > android.view.cts.PixelCopyTest > #TestWindowProducerCopyToRGBA16F > > Signed-off-by: Lin Johnson > --- > src/mesa/main/readpix.c | 2 ++ > 1 file

[Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-20 Thread Lin Johnson
Ext_color_buffer_half_float is using type GL_HALF_FLOAT and data_type GL_FLOAT. This fix Android CTS test android.view.cts.PixelCopyTest #TestWindowProducerCopyToRGBA16F Signed-off-by: Lin Johnson --- src/mesa/main/readpix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main/rea