Re: [Mesa-dev] [PATCH] mesa: need to check resource and set length even if bufSize is 0

2016-02-14 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 02/12/2016 07:19 PM, Ilia Mirkin wrote: This fixes a number of dEQP tests, such as: dEQP-GLES31.functional.program_interface_query.buffer_limited_query.resource_query It was expecting the length to be set even in the bufSize == 0 case. Also _mesa_get_program_resou

Re: [Mesa-dev] [PATCH] mesa: need to check resource and set length even if bufSize is 0

2016-02-14 Thread Ilia Mirkin
Hi Tapani, Looks like you added this function (and the logic I'm removing) in commit 2ab8de218 (mesa: implementation of glGetProgramResourceiv). Could you have a look at this change and see if it makes sense to you? Thanks, -ilia On Fri, Feb 12, 2016 at 12:19 PM, Ilia Mirkin wrote: > This fi

[Mesa-dev] [PATCH] mesa: need to check resource and set length even if bufSize is 0

2016-02-12 Thread Ilia Mirkin
This fixes a number of dEQP tests, such as: dEQP-GLES31.functional.program_interface_query.buffer_limited_query.resource_query It was expecting the length to be set even in the bufSize == 0 case. Also _mesa_get_program_resourceiv does some error checking on the resource which should probably happ