Re: [Mesa-dev] [PATCH] mesa: fix shininess check for ffvertex_prog v2

On Mon, May 4, 2015 at 5:54 PM, Tim Rowley wrote: > Switch to using VERT_BIT_GENERIC macro. Downloading piglet and > thought about how to test for this, but it doesn't look like I can > make a test pass/fail based on the tgsi generated (which is the most > straightforward way of testing this). N

[Mesa-dev] [PATCH] mesa: fix shininess check for ffvertex_prog v2

Switch to using VERT_BIT_GENERIC macro. Downloading piglet and thought about how to test for this, but it doesn't look like I can make a test pass/fail based on the tgsi generated (which is the most straightforward way of testing this). diff --git a/src/mesa/main/ffvertex_prog.c b/src/mesa/main/f

Re: [Mesa-dev] [PATCH] mesa: fix shininess check for ffvertex_prog

On Mon, May 4, 2015 at 3:57 PM, Tim Rowley wrote: > This was working before because it failed into generating the more > general case lighting equation. > > diff --git a/src/mesa/main/ffvertex_prog.c b/src/mesa/main/ffvertex_prog.c > index 7fdd9ba..cce0636 100644 > --- a/src/mesa/main/ffvertex_pro

[Mesa-dev] [PATCH] mesa: fix shininess check for ffvertex_prog

This was working before because it failed into generating the more general case lighting equation. diff --git a/src/mesa/main/ffvertex_prog.c b/src/mesa/main/ffvertex_prog.c index 7fdd9ba..cce0636 100644 --- a/src/mesa/main/ffvertex_prog.c +++ b/src/mesa/main/ffvertex_prog.c @@ -135,7 +135,7 @@ st