Re: [Mesa-dev] [PATCH] mesa: fix glsl version mismatch in compat profile

2018-04-10 Thread Ilia Mirkin
I think this used to work previously because something would clamp GLSLVersion to 130 for compat, and it no longer does. So probably just adding 30 is enough... On Tue, Apr 10, 2018 at 5:51 PM, Timothy Arceri wrote: > On 11/04/18 00:34, Ilia Mirkin wrote: >> >> What about GL 2.1 and 2.0 (and earl

Re: [Mesa-dev] [PATCH] mesa: fix glsl version mismatch in compat profile

2018-04-10 Thread Timothy Arceri
On 11/04/18 00:34, Ilia Mirkin wrote: What about GL 2.1 and 2.0 (and earlier where you could still have GLSL as an ext)? And does the GLSL version have to line up exactly for those? Or does this just need to be default: if (ctx->Version < 31) ctx->Const.GLSLVersion = MIN2(ctx->Const.GLSLVersi

Re: [Mesa-dev] [PATCH] mesa: fix glsl version mismatch in compat profile

2018-04-10 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Apr 10, 2018 at 7:40 AM, Timothy Arceri wrote: > Drivers that only support compat 3.0 were reporting GLSL 1.40 > support. This fixes issues with the menu of Dawn of War II. > > Fixes: a0c8b49284ef "mesa: enable OpenGL 3.1 with ARB_compatibility" > > Bugzi

Re: [Mesa-dev] [PATCH] mesa: fix glsl version mismatch in compat profile

2018-04-10 Thread Ilia Mirkin
What about GL 2.1 and 2.0 (and earlier where you could still have GLSL as an ext)? And does the GLSL version have to line up exactly for those? Or does this just need to be default: if (ctx->Version < 31) ctx->Const.GLSLVersion = MIN2(ctx->Const.GLSLVersion, 130) else ctx->Const.GLSLVersion =

[Mesa-dev] [PATCH] mesa: fix glsl version mismatch in compat profile

2018-04-10 Thread Timothy Arceri
Drivers that only support compat 3.0 were reporting GLSL 1.40 support. This fixes issues with the menu of Dawn of War II. Fixes: a0c8b49284ef "mesa: enable OpenGL 3.1 with ARB_compatibility" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105807 --- src/mesa/main/version.c | 8 ++-- 1