Re: [Mesa-dev] [PATCH] mesa: fix format selection for meta CopyTexSubImage()

2011-07-28 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/28/2011 08:54 AM, Brian Paul wrote: > When we do a glReadPixels into the temporary buffer, we don't want to > use GL_LUMINANCE, GL_LUMINANCE_ALPHA or GL_INTENSITY since they will > compute L=R+G+B which is not what we want. > > This bug has exis

Re: [Mesa-dev] [PATCH] mesa: fix format selection for meta CopyTexSubImage()

2011-07-28 Thread Eric Anholt
On Thu, 28 Jul 2011 09:54:04 -0600, Brian Paul wrote: > When we do a glReadPixels into the temporary buffer, we don't want to > use GL_LUMINANCE, GL_LUMINANCE_ALPHA or GL_INTENSITY since they will > compute L=R+G+B which is not what we want. > > This bug has existed all along but was only exposed

[Mesa-dev] [PATCH] mesa: fix format selection for meta CopyTexSubImage()

2011-07-28 Thread Brian Paul
When we do a glReadPixels into the temporary buffer, we don't want to use GL_LUMINANCE, GL_LUMINANCE_ALPHA or GL_INTENSITY since they will compute L=R+G+B which is not what we want. This bug has existed all along but was only exposed by the elimination of the driver hook for glCopyTexImage() in 58