Re: [Mesa-dev] [PATCH] mesa: fix UNCLAMPED_FLOAT_TO_UBYTE() macro for MSVC

2014-09-10 Thread Brian Paul
On 09/10/2014 12:02 PM, Ian Romanick wrote: On 09/10/2014 07:21 AM, Brian Paul wrote: MSVC replaces the "F" in "255.0F" with the macro argument which leads to an error. s/F/FLT/ to avoid that. It turns out we weren't using this macro at all on MSVC until the recent "mesa: Drop USE_IEEE define.

Re: [Mesa-dev] [PATCH] mesa: fix UNCLAMPED_FLOAT_TO_UBYTE() macro for MSVC

2014-09-10 Thread Ian Romanick
On 09/10/2014 07:21 AM, Brian Paul wrote: > MSVC replaces the "F" in "255.0F" with the macro argument which leads > to an error. s/F/FLT/ to avoid that. > > It turns out we weren't using this macro at all on MSVC until the > recent "mesa: Drop USE_IEEE define." change. > --- > src/mesa/main/macr

Re: [Mesa-dev] [PATCH] mesa: fix UNCLAMPED_FLOAT_TO_UBYTE() macro for MSVC

2014-09-10 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger Am 10.09.2014 16:21, schrieb Brian Paul: > MSVC replaces the "F" in "255.0F" with the macro argument which leads > to an error. s/F/FLT/ to avoid that. > > It turns out we weren't using this macro at all on MSVC until the > recent "mesa: Drop USE_IEEE define." ch

[Mesa-dev] [PATCH] mesa: fix UNCLAMPED_FLOAT_TO_UBYTE() macro for MSVC

2014-09-10 Thread Brian Paul
MSVC replaces the "F" in "255.0F" with the macro argument which leads to an error. s/F/FLT/ to avoid that. It turns out we weren't using this macro at all on MSVC until the recent "mesa: Drop USE_IEEE define." change. --- src/mesa/main/macros.h |9 + 1 file changed, 5 insertions(+),