Re: [Mesa-dev] [PATCH] mesa: fix GL_LUMINANCE handling in glGetTexImage

2012-09-11 Thread Anuj Phogat
On Mon, Sep 10, 2012 at 6:35 PM, Brian Paul wrote: > On Mon, Sep 10, 2012 at 3:16 PM, Anuj Phogat wrote: >> On Thu, Mar 8, 2012 at 7:19 PM, Brian Paul wrote: >>> There are several cases in which we need to explicity "rebase" colors >>> (ex: set G=B=0) when getting GL_LUMINANCE textures: >>> 1. I

Re: [Mesa-dev] [PATCH] mesa: fix GL_LUMINANCE handling in glGetTexImage

2012-09-10 Thread Brian Paul
On Mon, Sep 10, 2012 at 3:16 PM, Anuj Phogat wrote: > On Thu, Mar 8, 2012 at 7:19 PM, Brian Paul wrote: >> There are several cases in which we need to explicity "rebase" colors >> (ex: set G=B=0) when getting GL_LUMINANCE textures: >> 1. If the luminance texture is actually stored as rgba >> 2. I

Re: [Mesa-dev] [PATCH] mesa: fix GL_LUMINANCE handling in glGetTexImage

2012-09-10 Thread Anuj Phogat
On Thu, Mar 8, 2012 at 7:19 PM, Brian Paul wrote: > There are several cases in which we need to explicity "rebase" colors > (ex: set G=B=0) when getting GL_LUMINANCE textures: > 1. If the luminance texture is actually stored as rgba > 2. If getting a luminance texture, but returning rgba > 3. If g

Re: [Mesa-dev] [PATCH] mesa: fix GL_LUMINANCE handling in glGetTexImage

2012-03-09 Thread Jose Fonseca
Looks good to me. Jose - Original Message - > There are several cases in which we need to explicity "rebase" colors > (ex: set G=B=0) when getting GL_LUMINANCE textures: > 1. If the luminance texture is actually stored as rgba > 2. If getting a luminance texture, but returning rgba > 3. I

[Mesa-dev] [PATCH] mesa: fix GL_LUMINANCE handling in glGetTexImage

2012-03-08 Thread Brian Paul
There are several cases in which we need to explicity "rebase" colors (ex: set G=B=0) when getting GL_LUMINANCE textures: 1. If the luminance texture is actually stored as rgba 2. If getting a luminance texture, but returning rgba 3. If getting an rgba texture, but returning luminance Fixes https: