Re: [Mesa-dev] [PATCH] mesa: ensure that variable is initialized

2018-04-02 Thread Alejandro Piñeiro
Thanks for the patch! Reviewed-by: Alejandro Piñeiro On 03/04/18 00:36, Dylan Baker wrote: > Otherwise this variable will only be set if there are spirv shaders > present, but it's used regardless, resulting in undefined behavior. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=1058

Re: [Mesa-dev] [PATCH] mesa: ensure that variable is initialized

2018-04-02 Thread Mark Janes
Tested-by: Mark Janes Dylan Baker writes: > locally I've added: > Fixes: 16f6634e7fb5ada308e55b852cd49251e7f3f8b1 >("mesa/program: Link SPIR-V shaders using the SPIR-V code-path") > > Quoting Dylan Baker (2018-04-02 15:36:01) >> Otherwise this variable will only be set if there are spi

Re: [Mesa-dev] [PATCH] mesa: ensure that variable is initialized

2018-04-02 Thread Dylan Baker
locally I've added: Fixes: 16f6634e7fb5ada308e55b852cd49251e7f3f8b1 ("mesa/program: Link SPIR-V shaders using the SPIR-V code-path") Quoting Dylan Baker (2018-04-02 15:36:01) > Otherwise this variable will only be set if there are spirv shaders > present, but it's used regardless, resultin

[Mesa-dev] [PATCH] mesa: ensure that variable is initialized

2018-04-02 Thread Dylan Baker
Otherwise this variable will only be set if there are spirv shaders present, but it's used regardless, resulting in undefined behavior. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105820 CC: Alejandro Piñeiro CC: Mark Janes Signed-off-by: Dylan Baker --- src/mesa/program/ir_to_mesa.