Re: [Mesa-dev] [PATCH] mesa: don't memcmp() off the end of a cache key.

2013-04-01 Thread Ian Romanick
On 03/31/2013 05:04 PM, Chris Forbes wrote: Reported-by: `per` in #intel-gfx The size of the cache key varies, so store the actual size as well as the key blob itself, rather than just assuming it's the same as the size passed in. NOTE: This is a candidate for stable branches. Signed-off-by: C

Re: [Mesa-dev] [PATCH] mesa: don't memcmp() off the end of a cache key.

2013-04-01 Thread Adam Jackson
On Mon, 2013-04-01 at 13:04 +1300, Chris Forbes wrote: > @@ -38,6 +38,7 @@ struct cache_item > { > GLuint hash; > void *key; > + GLuint keysize; > struct gl_program *program; > struct cache_item *next; > }; Since GLuint is 32 bits, this creates another hole in the struct on LP

[Mesa-dev] [PATCH] mesa: don't memcmp() off the end of a cache key.

2013-03-31 Thread Chris Forbes
Reported-by: `per` in #intel-gfx The size of the cache key varies, so store the actual size as well as the key blob itself, rather than just assuming it's the same as the size passed in. NOTE: This is a candidate for stable branches. Signed-off-by: Chris Forbes --- src/mesa/program/prog_cache.