On 11/16/2011 09:54 AM, Vadim Girlin wrote:
On Wed, 2011-11-16 at 20:41 +0400, Vadim Girlin wrote:
On Wed, 2011-11-16 at 07:53 -0700, Brian Paul wrote:
In slow_read_depth_stencil_pixels_separate() we might have separate
depth and stencil buffers or a combined buffer. In the later case,
don't m
On Wed, 2011-11-16 at 20:41 +0400, Vadim Girlin wrote:
> On Wed, 2011-11-16 at 07:53 -0700, Brian Paul wrote:
> > In slow_read_depth_stencil_pixels_separate() we might have separate
> > depth and stencil buffers or a combined buffer. In the later case,
> > don't map the buffer twice. This functio
On Wed, 2011-11-16 at 07:53 -0700, Brian Paul wrote:
> In slow_read_depth_stencil_pixels_separate() we might have separate
> depth and stencil buffers or a combined buffer. In the later case,
> don't map the buffer twice. This function is used when the depth
> scale/bias pixel transfer values are
On 11/16/2011 08:43 AM, Jose Fonseca wrote:
Looks good Brian.
BTW, we should probably be more defensive about map failures on this code. This
is not a regression, as st_cb_readpixels.c also did a poor job.
Yeah, it's only a matter of time until we find a case where
MapRenderbuffer (or MapTex
Looks good Brian.
BTW, we should probably be more defensive about map failures on this code. This
is not a regression, as st_cb_readpixels.c also did a poor job.
Jose
- Original Message -
> In slow_read_depth_stencil_pixels_separate() we might have separate
> depth and stencil buffers o
In slow_read_depth_stencil_pixels_separate() we might have separate
depth and stencil buffers or a combined buffer. In the later case,
don't map the buffer twice. This function is used when the depth
scale/bias pixel transfer values are not the defaults.
Fixes http://bugs.freedesktop.org/show_bu