Re: [Mesa-dev] [PATCH] mesa: deal with vs_inputs as 64-bit unsigned integer

2017-11-28 Thread Juan A. Suarez Romero
On Tue, 2017-11-28 at 12:51 -0800, Ian Romanick wrote: > On 11/28/2017 02:01 AM, Iago Toral wrote: > > > > On Mon, 2017-11-27 at 18:37 +0100, Juan A. Suarez Romero wrote: > > > Commit 78942e ("mesa: shrink VERT_ATTRIB bitfields to 32 bits") uses > > > vs_prog_data->vs_inputs as if it were a 32-bit

Re: [Mesa-dev] [PATCH] mesa: deal with vs_inputs as 64-bit unsigned integer

2017-11-28 Thread Ian Romanick
On 11/28/2017 02:01 AM, Iago Toral wrote: > > On Mon, 2017-11-27 at 18:37 +0100, Juan A. Suarez Romero wrote: >> Commit 78942e ("mesa: shrink VERT_ATTRIB bitfields to 32 bits") uses >> vs_prog_data->vs_inputs as if it were a 32-bit unsigned integer. >> >> But actually it is a 64-bit integer, and a

Re: [Mesa-dev] [PATCH] mesa: deal with vs_inputs as 64-bit unsigned integer

2017-11-28 Thread Iago Toral
On Mon, 2017-11-27 at 18:37 +0100, Juan A. Suarez Romero wrote: > Commit 78942e ("mesa: shrink VERT_ATTRIB bitfields to 32 bits") uses > vs_prog_data->vs_inputs as if it were a 32-bit unsigned integer. > > But actually it is a 64-bit integer, and as such it is used in other > parts of Mesa code.

Re: [Mesa-dev] [PATCH] mesa: deal with vs_inputs as 64-bit unsigned integer

2017-11-27 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Nov 27, 2017 at 6:37 PM, Juan A. Suarez Romero wrote: > Commit 78942e ("mesa: shrink VERT_ATTRIB bitfields to 32 bits") uses > vs_prog_data->vs_inputs as if it were a 32-bit unsigned integer. > > But actually it is a 64-bit integer, and as such it is used

[Mesa-dev] [PATCH] mesa: deal with vs_inputs as 64-bit unsigned integer

2017-11-27 Thread Juan A. Suarez Romero
Commit 78942e ("mesa: shrink VERT_ATTRIB bitfields to 32 bits") uses vs_prog_data->vs_inputs as if it were a 32-bit unsigned integer. But actually it is a 64-bit integer, and as such it is used in other parts of Mesa code. It is worth to note that bits from the entire range are used, and not only