Re: [Mesa-dev] [PATCH] mesa: consolidate texstore functions

2011-12-22 Thread Jose Fonseca
Looks good to me. Jose - Original Message - > From: Brian Paul > > The code for storing 1D, 2D and 3D tex images (whole or sub-images) > was > all pretty similar. This consolidates those six paths. > > v2: rework switch statement to catch unexpected targets > --- > src/mesa/main/texs

[Mesa-dev] [PATCH] mesa: consolidate texstore functions

2011-12-22 Thread Brian Paul
From: Brian Paul The code for storing 1D, 2D and 3D tex images (whole or sub-images) was all pretty similar. This consolidates those six paths. v2: rework switch statement to catch unexpected targets --- src/mesa/main/texstore.c | 484 +++--- 1 files ch

Re: [Mesa-dev] [PATCH] mesa: consolidate texstore functions

2011-12-22 Thread Brian Paul
On Wed, Dec 21, 2011 at 12:48 PM, Jose Fonseca wrote: > Looks like a nice cleanup. > > I wonder if it wouldn't be more future proof to explicit add cases for > GL_TEXTURE_2D, cube face, etc., and have default be an assertion failure. Yeah, that's probably a good idea. -Brian ___

Re: [Mesa-dev] [PATCH] mesa: consolidate texstore functions

2011-12-21 Thread Jose Fonseca
Looks like a nice cleanup. I wonder if it wouldn't be more future proof to explicit add cases for GL_TEXTURE_2D, cube face, etc., and have default be an assertion failure. Jose - Original Message - > From: Brian Paul > > The code for storing 1D, 2D and 3D tex images (whole or sub-imag

[Mesa-dev] [PATCH] mesa: consolidate texstore functions

2011-12-19 Thread Brian Paul
From: Brian Paul The code for storing 1D, 2D and 3D tex images (whole or sub-images) was all pretty similar. This consolidates those six paths. --- src/mesa/main/texstore.c | 475 ++ 1 files changed, 144 insertions(+), 331 deletions(-) diff --git a/