Re: [Mesa-dev] [PATCH] mesa: check that uniform exists in glUniform* functions

2014-09-12 Thread Ian Romanick
On 09/12/2014 12:36 AM, Tapani Pälli wrote: > Remap table for uniforms may contain empty entries when using explicit > uniform locations. If no active/inactive variable exists with given > location, remap table contains NULL. > > v2: move remap table bounds check before existence check (Ian Romani

[Mesa-dev] [PATCH] mesa: check that uniform exists in glUniform* functions

2014-09-12 Thread Tapani Pälli
Remap table for uniforms may contain empty entries when using explicit uniform locations. If no active/inactive variable exists with given location, remap table contains NULL. v2: move remap table bounds check before existence check (Ian Romanick) Signed-off-by: Tapani Pälli Tested-by: Erik Faye

Re: [Mesa-dev] [PATCH] mesa: check that uniform exists in glUniform* functions

2014-09-11 Thread Tapani Pälli
On 09/11/2014 09:39 PM, Ian Romanick wrote: > On 08/28/2014 12:58 AM, Tapani Pälli wrote: >> Remap table for uniforms may contain empty entries when using explicit >> uniform locations. If no active/inactive variable exists with given >> location, remap table contains NULL. >> >> Signed-off-by: Tap

Re: [Mesa-dev] [PATCH] mesa: check that uniform exists in glUniform* functions

2014-09-11 Thread Erik Faye-Lund
On Thu, Sep 11, 2014 at 8:39 PM, Ian Romanick wrote: > On 08/28/2014 12:58 AM, Tapani Pälli wrote: >> Remap table for uniforms may contain empty entries when using explicit >> uniform locations. If no active/inactive variable exists with given >> location, remap table contains NULL. >> >> Signed-o

Re: [Mesa-dev] [PATCH] mesa: check that uniform exists in glUniform* functions

2014-09-11 Thread Ian Romanick
On 08/28/2014 12:58 AM, Tapani Pälli wrote: > Remap table for uniforms may contain empty entries when using explicit > uniform locations. If no active/inactive variable exists with given > location, remap table contains NULL. > > Signed-off-by: Tapani Pälli > --- > src/mesa/main/uniform_query.cp

Re: [Mesa-dev] [PATCH] mesa: check that uniform exists in glUniform* functions

2014-09-11 Thread Tapani
On 09/11/2014 03:12 PM, Erik Faye-Lund wrote: On Thu, Aug 28, 2014 at 9:58 AM, Tapani Pälli wrote: Remap table for uniforms may contain empty entries when using explicit uniform locations. If no active/inactive variable exists with given location, remap table contains NULL. Signed-off-by: Tapa

Re: [Mesa-dev] [PATCH] mesa: check that uniform exists in glUniform* functions

2014-09-11 Thread Erik Faye-Lund
On Thu, Aug 28, 2014 at 9:58 AM, Tapani Pälli wrote: > Remap table for uniforms may contain empty entries when using explicit > uniform locations. If no active/inactive variable exists with given > location, remap table contains NULL. > > Signed-off-by: Tapani Pälli > --- > src/mesa/main/uniform

[Mesa-dev] [PATCH] mesa: check that uniform exists in glUniform* functions

2014-08-28 Thread Tapani Pälli
Remap table for uniforms may contain empty entries when using explicit uniform locations. If no active/inactive variable exists with given location, remap table contains NULL. Signed-off-by: Tapani Pälli --- src/mesa/main/uniform_query.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d