Re: [Mesa-dev] [PATCH] mesa: check for no matrix change in _mesa_LoadMatrixf()

2016-09-15 Thread Charmaine Lee
Looks good. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, September 15, 2016 8:34 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] mesa: check for no matrix change in _mesa_LoadMatrixf() Some apps issue redundant gl

Re: [Mesa-dev] [PATCH] mesa: check for no matrix change in _mesa_LoadMatrixf()

2016-09-15 Thread Kenneth Graunke
On Thursday, September 15, 2016 9:34:50 AM PDT Brian Paul wrote: > Some apps issue redundant glLoadMatrixf() calls with the same matrix. > Try to avoid setting dirty state in that situation. > > This reduces the number of constant buffer updates by about half in > ET Quake Wars. > > Tested with P

[Mesa-dev] [PATCH] mesa: check for no matrix change in _mesa_LoadMatrixf()

2016-09-15 Thread Brian Paul
Some apps issue redundant glLoadMatrixf() calls with the same matrix. Try to avoid setting dirty state in that situation. This reduces the number of constant buffer updates by about half in ET Quake Wars. Tested with Piglit, ETQW, Sauerbraten, Google Earth, etc. --- src/mesa/main/matrix.c | 8 ++