Re: [Mesa-dev] [PATCH] mesa: add missing error check in _mesa_CallLists()

2016-02-08 Thread Ian Romanick
On 02/08/2016 05:06 PM, Brian Paul wrote: > Generate GL_INVALID_VALUE if n < 0. Return early if n==0 or lists==NULL. > > v2: fix formatting, also check for lists==NULL. You were correct that I was looking at save_CallLists before. Reviewed-by: Ian Romanick > --- > src/mesa/main/dlist.c | 8 +

[Mesa-dev] [PATCH] mesa: add missing error check in _mesa_CallLists()

2016-02-08 Thread Brian Paul
Generate GL_INVALID_VALUE if n < 0. Return early if n==0 or lists==NULL. v2: fix formatting, also check for lists==NULL. --- src/mesa/main/dlist.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index cd8e3b6..65f0929 100644 --- a/src/mes

Re: [Mesa-dev] [PATCH] mesa: add missing error check in _mesa_CallLists()

2016-02-08 Thread Brian Paul
On 02/08/2016 05:07 PM, Ian Romanick wrote: On 02/08/2016 02:31 PM, Brian Paul wrote: Generate GL_INVALID_VALUE if n < 0. Return early if n==0. --- src/mesa/main/dlist.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index cd8e3b6..

Re: [Mesa-dev] [PATCH] mesa: add missing error check in _mesa_CallLists()

2016-02-08 Thread Ian Romanick
On 02/08/2016 02:31 PM, Brian Paul wrote: > Generate GL_INVALID_VALUE if n < 0. Return early if n==0. > --- > src/mesa/main/dlist.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c > index cd8e3b6..24aea35 100644 > --- a/src/mesa/mai

[Mesa-dev] [PATCH] mesa: add missing error check in _mesa_CallLists()

2016-02-08 Thread Brian Paul
Generate GL_INVALID_VALUE if n < 0. Return early if n==0. --- src/mesa/main/dlist.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index cd8e3b6..24aea35 100644 --- a/src/mesa/main/dlist.c +++ b/src/mesa/main/dlist.c @@ -9105,6 +9105,15