Re: [Mesa-dev] [PATCH] mesa: Validate the result of pipe_transfer_map in make_texture

2018-09-10 Thread Marek Olšák
Hi, thanks for the patch. I've sent version 2 of the patch with additional fixes to this list. Marek On Sun, Sep 9, 2018 at 10:08 PM, Josh Pieper wrote: > And apparently I am incapable of operating git send-email, so it > failed to include my context: > > When using Freecad, I was getting inter

[Mesa-dev] [PATCH] mesa: Validate the result of pipe_transfer_map in make_texture (v2)

2018-09-10 Thread Marek Olšák
From: Josh Pieper When using Freecad, I was getting intermittent segfaults inside of mesa. I traced it down to this path in st_cb_drawpixels.c where the result of pipe_transfer_map wasn't being checked. In my case, it was returning NULL because nouveau_bo_new returned ENOENT. I'm by no means a

Re: [Mesa-dev] [PATCH] mesa: Validate the result of pipe_transfer_map in make_texture

2018-09-09 Thread Josh Pieper
And apparently I am incapable of operating git send-email, so it failed to include my context: When using Freecad, I was getting intermittent segfaults inside of mesa. I traced it down to this path in st_cb_drawpixels.c where the result of pipe_transfer_map wasn't being checked. In my case, it w

[Mesa-dev] [PATCH] mesa: Validate the result of pipe_transfer_map in make_texture

2018-09-09 Thread Josh Pieper
--- src/mesa/state_tracker/st_cb_drawpixels.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_drawpixels.c b/src/mesa/state_tracker/st_cb_drawpixels.c index cb50b7104a..8d39b8a01b 100644 --- a/src/mesa/state_tracker/st_cb_drawpixels.c +++ b/src/mesa/state_track