Re: [Mesa-dev] [PATCH] mesa: Reference the array object in vbo_bind_arrays()

2013-04-15 Thread Fredrik Höglund
On Monday 15 April 2013, Marek Olšák wrote: > I think the problem is _DrawArrays points to a deleted VAO, because we > don't reset _DrawArrays to NULL. The attached patch should fix it. Please > review. I think we should check the first enabled array, since the vbo module will set up the others to

Re: [Mesa-dev] [PATCH] mesa: Reference the array object in vbo_bind_arrays()

2013-04-15 Thread Marek Olšák
I think the problem is _DrawArrays points to a deleted VAO, because we don't reset _DrawArrays to NULL. The attached patch should fix it. Please review. Marek On Mon, Apr 15, 2013 at 7:56 PM, Fredrik Höglund wrote: > Otherwise gl_array_attrib::_DrawArrays can end up pointing at free'd > memory

[Mesa-dev] [PATCH] mesa: Reference the array object in vbo_bind_arrays()

2013-04-15 Thread Fredrik Höglund
Otherwise gl_array_attrib::_DrawArrays can end up pointing at free'd memory when the array object is deleted. Note: This is a candidate for the stable branches. --- The slightly longer explanation is that the mesa state tracker accesses _DrawArrays during state validation, and state validation ca