Re: [Mesa-dev] [PATCH] mesa: Prevent classic swrast crash on a surfaceless context v2.

2019-05-27 Thread Mathias Fröhlich
Pushed that. Thanks! best Mathias On Monday, 27 May 2019 17:34:29 CEST Marek Olšák wrote: > Reviewed-by: Marek Olšák > > M. > > On Mon, May 27, 2019, 4:17 AM wrote: > > > From: Mathias Fröhlich > > > > Hi Emil, > > > > thanks for that hint to look at _mesa_get_incomplete_framebuffer. > > Tha

Re: [Mesa-dev] [PATCH] mesa: Prevent classic swrast crash on a surfaceless context v2.

2019-05-27 Thread Emil Velikov
On 2019/05/27, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Hi Emil, > > thanks for that hint to look at _mesa_get_incomplete_framebuffer. > That one seems definitely more appropriate! > > Though, I miss a bit the idea how I can create either a sensible > helper function for th

Re: [Mesa-dev] [PATCH] mesa: Prevent classic swrast crash on a surfaceless context v2.

2019-05-27 Thread Marek Olšák
Reviewed-by: Marek Olšák M. On Mon, May 27, 2019, 4:17 AM wrote: > From: Mathias Fröhlich > > Hi Emil, > > thanks for that hint to look at _mesa_get_incomplete_framebuffer. > That one seems definitely more appropriate! > > Though, I miss a bit the idea how I can create either a sensible > hel

[Mesa-dev] [PATCH] mesa: Prevent classic swrast crash on a surfaceless context v2.

2019-05-27 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi Emil, thanks for that hint to look at _mesa_get_incomplete_framebuffer. That one seems definitely more appropriate! Though, I miss a bit the idea how I can create either a sensible helper function for that task or how I can create something above in the call stack to t

Re: [Mesa-dev] [PATCH] mesa: Prevent classic swrast crash on a surfaceless context.

2019-05-15 Thread Emil Velikov
On Wed, 15 May 2019 at 08:26, wrote: > > From: Mathias Fröhlich > > Hi all, > > One small fix below. > > Please review! > > best > > Mathias > > > > > > Running swrast with the new device egl extensions piglit test > brings up this failure. Fix that by adding some NULL pointer > checks. > From a

[Mesa-dev] [PATCH] mesa: Prevent classic swrast crash on a surfaceless context.

2019-05-15 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi all, One small fix below. Please review! best Mathias Running swrast with the new device egl extensions piglit test brings up this failure. Fix that by adding some NULL pointer checks. Signed-off-by: Mathias Fröhlich --- src/mesa/main/fbobject.c | 11 ++--