Re: [Mesa-dev] [PATCH] mesa: Fix setup of LocalParams array.

2013-11-20 Thread Eric Anholt
Brian Paul writes: > On 11/18/2013 08:57 PM, Michel Dänzer wrote: >> On Mon, 2013-11-18 at 17:27 -0800, Eric Anholt wrote: >>> i965 passed piglit, but swrast and gallium both segfaulted without this. >>> i965 happened to work because it never ran _mesa_load_state_parameters() >>> on the new progr

Re: [Mesa-dev] [PATCH] mesa: Fix setup of LocalParams array.

2013-11-20 Thread Brian Paul
On 11/18/2013 08:57 PM, Michel Dänzer wrote: On Mon, 2013-11-18 at 17:27 -0800, Eric Anholt wrote: i965 passed piglit, but swrast and gallium both segfaulted without this. i965 happened to work because it never ran _mesa_load_state_parameters() on the new program before the test called glProgram

Re: [Mesa-dev] [PATCH] mesa: Fix setup of LocalParams array.

2013-11-18 Thread Michel Dänzer
On Mon, 2013-11-18 at 17:27 -0800, Eric Anholt wrote: > i965 passed piglit, but swrast and gallium both segfaulted without this. > i965 happened to work because it never ran _mesa_load_state_parameters() > on the new program before the test called glProgramLocalParameter(), which > was allocating a

[Mesa-dev] [PATCH] mesa: Fix setup of LocalParams array.

2013-11-18 Thread Eric Anholt
i965 passed piglit, but swrast and gallium both segfaulted without this. i965 happened to work because it never ran _mesa_load_state_parameters() on the new program before the test called glProgramLocalParameter(), which was allocating a LocalParams array for the fallback path. Bugzilla: https://b

Re: [Mesa-dev] [PATCH] mesa: Fix setup of LocalParams array.

2013-11-18 Thread Eric Anholt
Brian Paul writes: > On 11/18/2013 04:25 PM, Brian Paul wrote: >> On 11/18/2013 11:07 AM, Eric Anholt wrote: >>> i965 passed piglit, but swrast and gallium both segfaulted without this. >>> i965 happened to work because it never ran _mesa_load_state_parameters() >>> on the new program before the

Re: [Mesa-dev] [PATCH] mesa: Fix setup of LocalParams array.

2013-11-18 Thread Brian Paul
On 11/18/2013 04:25 PM, Brian Paul wrote: On 11/18/2013 11:07 AM, Eric Anholt wrote: i965 passed piglit, but swrast and gallium both segfaulted without this. i965 happened to work because it never ran _mesa_load_state_parameters() on the new program before the test called glProgramLocalParameter

Re: [Mesa-dev] [PATCH] mesa: Fix setup of LocalParams array.

2013-11-18 Thread Brian Paul
On 11/18/2013 11:07 AM, Eric Anholt wrote: i965 passed piglit, but swrast and gallium both segfaulted without this. i965 happened to work because it never ran _mesa_load_state_parameters() on the new program before the test called glProgramLocalParameter(), which was allocating a LocalParams arra

[Mesa-dev] [PATCH] mesa: Fix setup of LocalParams array.

2013-11-18 Thread Eric Anholt
i965 passed piglit, but swrast and gallium both segfaulted without this. i965 happened to work because it never ran _mesa_load_state_parameters() on the new program before the test called glProgramLocalParameter(), which was allocating a LocalParams array for the fallback path. Bugzilla: https://b