Re: [Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags, v2

2013-12-22 Thread Lauri Kasanen
On Sun, 22 Dec 2013 08:01:26 -0800 Matt Turner wrote: > On Sun, Dec 22, 2013 at 1:39 AM, Lauri Kasanen wrote: > > On Fri, 20 Dec 2013 17:06:03 -0800 > > Matt Turner wrote: > > > >> On Thu, Dec 19, 2013 at 11:43 AM, Lauri Kasanen wrote: > >> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi

Re: [Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags, v2

2013-12-22 Thread Matt Turner
On Sun, Dec 22, 2013 at 1:39 AM, Lauri Kasanen wrote: > On Fri, 20 Dec 2013 17:06:03 -0800 > Matt Turner wrote: > >> On Thu, Dec 19, 2013 at 11:43 AM, Lauri Kasanen wrote: >> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72708 >> > >> > Signed-off-by: Lauri Kasanen >> > --- >> >> Tha

Re: [Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags, v2

2013-12-22 Thread Lauri Kasanen
On Fri, 20 Dec 2013 17:06:03 -0800 Matt Turner wrote: > On Thu, Dec 19, 2013 at 11:43 AM, Lauri Kasanen wrote: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72708 > > > > Signed-off-by: Lauri Kasanen > > --- > > Thanks, R-b and pushed. Apparently this commit also fixed non-x86 bu

Re: [Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags, v2

2013-12-20 Thread Matt Turner
On Thu, Dec 19, 2013 at 11:43 AM, Lauri Kasanen wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72708 > > Signed-off-by: Lauri Kasanen > --- Thanks, R-b and pushed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.f

Re: [Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags

2013-12-20 Thread Chad Versace
On 12/19/2013 01:50 AM, Lauri Kasanen wrote: On Wed, 18 Dec 2013 17:57:16 -0800 Matt Turner wrote: On Tue, Dec 17, 2013 at 7:15 AM, Lauri Kasanen It seems to me that the Intel code that uses this SSE4.1 function is still buggy, as it has no runtime check - would it not crash if built on a

[Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags, v2

2013-12-19 Thread Lauri Kasanen
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72708 Signed-off-by: Lauri Kasanen --- configure.ac| 6 m4/ax_check_compile_flag.m4 | 72 + src/mesa/Makefile.am| 6 +++- 3 files changed, 83 insertions(+), 1 deletio

Re: [Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags

2013-12-19 Thread Matt Turner
On Thu, Dec 19, 2013 at 1:50 AM, Lauri Kasanen wrote: > On Wed, 18 Dec 2013 17:57:16 -0800 > Matt Turner wrote: > >> On Tue, Dec 17, 2013 at 7:15 AM, Lauri Kasanen wrote: >> > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=72708 >> >> Make this "Bugzilla: ..." > > Sure, will do. But there a

Re: [Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags

2013-12-19 Thread Kenneth Graunke
On 12/19/2013 01:50 AM, Lauri Kasanen wrote: [snip] > Gallium has a cpu detect function that includes a SSE 4.1 cap. Perhaps > you'd like to move it to a common area and make use of it for runtime > detection? Yes, that would be far better. The Mesa code has really rotted - it only does CPU detec

Re: [Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags

2013-12-19 Thread Lauri Kasanen
On Wed, 18 Dec 2013 17:57:16 -0800 Matt Turner wrote: > On Tue, Dec 17, 2013 at 7:15 AM, Lauri Kasanen wrote: > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=72708 > > Make this "Bugzilla: ..." Sure, will do. But there are both conventions used, for example see: 0b16042377a 8bc7673ef87

Re: [Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags

2013-12-18 Thread Matt Turner
On Tue, Dec 17, 2013 at 7:15 AM, Lauri Kasanen wrote: > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=72708 Make this "Bugzilla: ..." > It seems to me that the Intel code that uses this SSE4.1 function > is still buggy, as it has no runtime check - would it not crash > if built on a SSE4-c

[Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags

2013-12-17 Thread Lauri Kasanen
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=72708 It seems to me that the Intel code that uses this SSE4.1 function is still buggy, as it has no runtime check - would it not crash if built on a SSE4-capable system but used with a lower-class cpu? i965 systems = LGA775 = Pentium4 without S