Re: [Mesa-dev] [PATCH] mesa: Document ati_fragment_shader::cur_pass

2017-11-28 Thread Roland Scheidegger
Looks alright to me too. And it's shorter :-). Roland Am 28.11.2017 um 11:17 schrieb Miklós Máté: > Hi, > > I've already prepared a patch that documents this, I was going to post > it with the v2 of this series. My version looks like this: > > diff --git a/src/mesa/main/mtypes.h b/src/mesa/main

Re: [Mesa-dev] [PATCH] mesa: Document ati_fragment_shader::cur_pass

2017-11-28 Thread Miklós Máté
Hi, I've already prepared a patch that documents this, I was going to post it with the v2 of this series. My version looks like this: diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 6b5c5bbb36..9c04a3c727 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -2

Re: [Mesa-dev] [PATCH] mesa: Document ati_fragment_shader::cur_pass

2017-11-27 Thread Roland Scheidegger
I really don't think you wanted to remove the cur_pass variable there :-). With that fixed, Reviewed-by: Roland Scheidegger Am 28.11.2017 um 04:10 schrieb Ian Romanick: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > Having this information would have helped me review recent patch

[Mesa-dev] [PATCH] mesa: Document ati_fragment_shader::cur_pass

2017-11-27 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- Having this information would have helped me review recent patches from Miklós... src/mesa/main/mtypes.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 2f2163