Re: [Mesa-dev] [PATCH] mesa/vbo: fix invalid min/max indexes

2017-05-08 Thread Rob Clark
On Mon, May 8, 2017 at 5:29 PM, Ilia Mirkin wrote: > On Mon, May 8, 2017 at 5:27 PM, Rob Clark wrote: >> On Mon, May 8, 2017 at 4:57 PM, Marek Olšák wrote: >>> I personally find the assertions unnecessary because the bug has been >>> discovered and fixed by this patch, and this code is unlikely

Re: [Mesa-dev] [PATCH] mesa/vbo: fix invalid min/max indexes

2017-05-08 Thread Ilia Mirkin
On Mon, May 8, 2017 at 5:27 PM, Rob Clark wrote: > On Mon, May 8, 2017 at 4:57 PM, Marek Olšák wrote: >> I personally find the assertions unnecessary because the bug has been >> discovered and fixed by this patch, and this code is unlikely to >> change. Anyway: >> >> Reviewed-by: Marek Olšák > >

Re: [Mesa-dev] [PATCH] mesa/vbo: fix invalid min/max indexes

2017-05-08 Thread Rob Clark
On Mon, May 8, 2017 at 4:57 PM, Marek Olšák wrote: > I personally find the assertions unnecessary because the bug has been > discovered and fixed by this patch, and this code is unlikely to > change. Anyway: > > Reviewed-by: Marek Olšák I don't suppose there is something like debug_assert() (ie.

Re: [Mesa-dev] [PATCH] mesa/vbo: fix invalid min/max indexes

2017-05-08 Thread Rob Clark
On Mon, May 8, 2017 at 4:58 PM, Dieter Nützel wrote: > Hello Rob, > > FWIW this is > Tested-by: Dieter Nützel > > on radeonsi/RX580 (my first on new GREAT hardware) ;-) > But 'glmark2 -b ideas' worked for me on radeonsi without this. > thanks.. actually radeonsi never looks at info->min/max_inde

Re: [Mesa-dev] [PATCH] mesa/vbo: fix invalid min/max indexes

2017-05-08 Thread Dieter Nützel
Hello Rob, FWIW this is Tested-by: Dieter Nützel on radeonsi/RX580 (my first on new GREAT hardware) ;-) But 'glmark2 -b ideas' worked for me on radeonsi without this. Greetings, Dieter Am 08.05.2017 22:37, schrieb Rob Clark: Fixes: c3f37e9b ("st/mesa: use min_index and max_index directly from

Re: [Mesa-dev] [PATCH] mesa/vbo: fix invalid min/max indexes

2017-05-08 Thread Marek Olšák
I personally find the assertions unnecessary because the bug has been discovered and fixed by this patch, and this code is unlikely to change. Anyway: Reviewed-by: Marek Olšák Marek On Mon, May 8, 2017 at 10:37 PM, Rob Clark wrote: > Fixes: c3f37e9b ("st/mesa: use min_index and max_index direc

[Mesa-dev] [PATCH] mesa/vbo: fix invalid min/max indexes

2017-05-08 Thread Rob Clark
Fixes: c3f37e9b ("st/mesa: use min_index and max_index directly from vbo") Signed-off-by: Rob Clark --- I haven't had a chance to piglit this yet, but it does fix the regression w/ 'glmark2 -b ideas'. src/mesa/vbo/vbo_exec_array.c | 22 -- 1 file changed, 16 insertions(+), 6