Re: [Mesa-dev] [PATCH] mesa/tnl_dd: Fix clang constant-logical-operand warnings.

2014-06-04 Thread Matt Turner
On Wed, Jun 4, 2014 at 4:48 PM, Vinson Lee wrote: > This patch fixes these clang constant-logical-operand warnings. > > ../../../../../src/mesa/tnl_dd/t_dd_tritmp.h:130:32: warning: use of logical > '||' with constant operand [-Wconstant-logical-operand] >if (DO_TWOSIDE || DO_OFFSET || DO_UNF

Re: [Mesa-dev] [PATCH] mesa/tnl_dd: Fix clang constant-logical-operand warnings.

2014-06-04 Thread Brian Paul
Reviewed-by: Brian Paul But I think you could trim down the commit message to give just one example. On 06/04/2014 04:48 PM, Vinson Lee wrote: This patch fixes these clang constant-logical-operand warnings. ../../../../../src/mesa/tnl_dd/t_dd_tritmp.h:130:32: warning: use of logical '||' wi

[Mesa-dev] [PATCH] mesa/tnl_dd: Fix clang constant-logical-operand warnings.

2014-06-04 Thread Vinson Lee
This patch fixes these clang constant-logical-operand warnings. ../../../../../src/mesa/tnl_dd/t_dd_tritmp.h:130:32: warning: use of logical '||' with constant operand [-Wconstant-logical-operand] if (DO_TWOSIDE || DO_OFFSET || DO_UNFILLED || DO_TWOSTENCIL) ^ ~~