Re: [Mesa-dev] [PATCH] mesa/st: Standardize some asserts to use !"foo"

2016-08-31 Thread Eric Engestrom
On Tue, Aug 30, 2016 at 12:09:52PM +0200, Michael Schellenberger Costa wrote: > These are the final asserts in the tree that do not follow the pattern > assert(!"foo"). To simplify spotting of (mostly) incorrect asserts via git > grep "assert(\"" rewrite them into the standard form. > > Signed-o

Re: [Mesa-dev] [PATCH] mesa/st: Standardize some asserts to use !"foo"

2016-08-31 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 08/30/2016 08:09 PM, Michael Schellenberger Costa wrote: > These are the final asserts in the tree that do not follow the pattern > assert(!"foo"). To simplify spotting of (mostly) incorrect asserts via git > grep "assert(\"" rewrite them into the standard for

[Mesa-dev] [PATCH] mesa/st: Standardize some asserts to use !"foo"

2016-08-30 Thread Michael Schellenberger Costa
These are the final asserts in the tree that do not follow the pattern assert(!"foo"). To simplify spotting of (mostly) incorrect asserts via git grep "assert(\"" rewrite them into the standard form. Signed-off-by: Michael Schellenberger Costa --- src/mesa/state_tracker/st_atom_blend.c | 4 ++-

Re: [Mesa-dev] [PATCH] mesa/st: Standardize some asserts to use !"foo"

2016-08-30 Thread Brian Paul
On 08/30/2016 04:09 AM, Michael Schellenberger Costa wrote: These are the final asserts in the tree that do not follow the pattern assert(!"foo"). To simplify spotting of (mostly) incorrect asserts via git grep "assert(\"" rewrite them into the standard form. Signed-off-by: Michael Schellenber