Re: [Mesa-dev] [PATCH] mesa/st: Fix NULL access if no fragment shader is bound

This can happen when using glDispatchCompute while having only a compute shader bound. As far as I can see st_upload_constants is only called with shader_type = PIPE_SHADER_FRAGMENT if st->fp is not null, and in other calls the second part of the if condition does not get executed. - Bas On Mon,

Re: [Mesa-dev] [PATCH] mesa/st: Fix NULL access if no fragment shader is bound

On 03/28/2016 05:01 PM, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen --- src/mesa/state_tracker/st_atom_constbuf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_constbuf.c b/src/mesa/state_tracker/st_atom_constbuf.c index

Re: [Mesa-dev] [PATCH] mesa/st: Fix NULL access if no fragment shader is bound

Pushed, thanks. Marek On Mon, Mar 28, 2016 at 5:01 PM, Bas Nieuwenhuizen wrote: > Signed-off-by: Bas Nieuwenhuizen > --- > src/mesa/state_tracker/st_atom_constbuf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/state_tracker/st_atom_constbuf.c > b/src/m

[Mesa-dev] [PATCH] mesa/st: Fix NULL access if no fragment shader is bound

Signed-off-by: Bas Nieuwenhuizen --- src/mesa/state_tracker/st_atom_constbuf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_constbuf.c b/src/mesa/state_tracker/st_atom_constbuf.c index 4d9b344..a980dbe 100644 --- a/src/mesa/state_tracker/