Re: [Mesa-dev] [PATCH] mesa/shaderapi: Do a dry run of linking an in-use program

2017-11-07 Thread Timothy Arceri
On 08/11/17 02:35, Neil Roberts wrote: Timothy Arceri writes: You’re right, I think that would be a better way to handle it. I guess if this was done then you don’t really need the second link. There are several pointers for the uniform state that you would need to keep and I think there is

Re: [Mesa-dev] [PATCH] mesa/shaderapi: Do a dry run of linking an in-use program

2017-11-07 Thread Neil Roberts
Timothy Arceri writes: >> You’re right, I think that would be a better way to handle it. I guess >> if this was done then you don’t really need the second link. There are >> several pointers for the uniform state that you would need to keep and I >> think there is more state than just the uniform

Re: [Mesa-dev] [PATCH] mesa/shaderapi: Do a dry run of linking an in-use program

2017-11-07 Thread Emil Velikov
Hi Neil, On 2 November 2017 at 18:35, Neil Roberts wrote: > If an in-use program is unsuccessfully linked, the GL spec requires > that the executable and the uniform state of the program should remain > until a new program is bound. Previously this sort of worked in Mesa > except that it would fr

Re: [Mesa-dev] [PATCH] mesa/shaderapi: Do a dry run of linking an in-use program

2017-11-07 Thread Timothy Arceri
On 07/11/17 19:15, Neil Roberts wrote: Timothy Arceri writes: I think I'd rather see this handled by releasing the uniforms only after the second link is successful and using a temp/fallback pointer to hold it until then. We need to do a similar type of thing with shader source and the shader

Re: [Mesa-dev] [PATCH] mesa/shaderapi: Do a dry run of linking an in-use program

2017-11-07 Thread Neil Roberts
Timothy Arceri writes: > I think I'd rather see this handled by releasing the uniforms only after > the second link is successful and using a temp/fallback pointer to hold > it until then. We need to do a similar type of thing with shader source > and the shader cache e.g [1]. > > [1] > https

Re: [Mesa-dev] [PATCH] mesa/shaderapi: Do a dry run of linking an in-use program

2017-11-02 Thread Timothy Arceri
I think I'd rather see this handled by releasing the uniforms only after the second link is successful and using a temp/fallback pointer to hold it until then. We need to do a similar type of thing with shader source and the shader cache e.g [1]. [1] https://cgit.freedesktop.org/mesa/mesa/com

[Mesa-dev] [PATCH] mesa/shaderapi: Do a dry run of linking an in-use program

2017-11-02 Thread Neil Roberts
If an in-use program is unsuccessfully linked, the GL spec requires that the executable and the uniform state of the program should remain until a new program is bound. Previously this sort of worked in Mesa except that it would free the uniform state before attempting to link. At least on i965 thi